Add option to set rcv_buffer for UDP inputs #9906

cachedout · 2019-01-04T23:13:47Z

This resolves #9895.

It replaces the previous use of ListenPacket with a plain UDP listener. However, the upstream interface is the same and this continues to pass the inputsource tests for UDP.

This does not include additional testing and intentionally bypasses the logic for setting the socket option during test. If tests for this are desireable, I'm happy to write some.

elasticmachine · 2019-01-04T23:13:48Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

ph

Thanks @cachedout for the PR, code looks fine only minor changes. Also can you update the documentation and also the YAML files to mention the new option? You will need to run make update to propagate the changes and commit the changes to this PR.

ph · 2019-01-09T18:53:31Z

filebeat/inputsource/udp/server.go

+	if socketSize != 0 {
+		err = u.Listener.SetReadBuffer(socketSize)
+	}
+


Looking at the SetReadBuffer documentation it accepts the number of bytes, the cfgtype.Bytes is already the number of bytes set as a int64, so you only need to convert it to int.

Also, it's a good pratice in go to handle the error right away, I am suggesting the following changes:

udpAdddr, err := net.ResolveUDPAddr("udp", u.config.Host) if err != nil { return err } u.Listener, err = net.ListenUDP("udp", udpAdddr) if err != nil { return err } if socketSize != 0 { if err := u.Listener.SetReadBuffer(int(u.config.ReadBuffer)); err != nil { return err } }

ph · 2019-01-09T18:56:43Z

filebeat/input/udp/config.go

@@ -35,7 +35,8 @@ var defaultConfig = config{
 		// TODO: What should be default port?
 		Host: "localhost:8080",
 		// TODO: What should be the default timeout?
-		Timeout: time.Minute * 5,
+		Timeout:    time.Minute * 5,
+		ReadBuffer: 0 * humanize.KiByte,


No need to set a default value since intX are set to 0 by default.

ph · 2019-01-09T19:01:39Z

@cachedout Also make sure to run make check to make sure that the changes follow the style guide, you can fix most of the errors using the make fmt command.

And you need to add a changelog entry to the CHANGELOG at https://github.com/elastic/beats/blob/master/CHANGELOG.next.asciidoc

…kia module (elastic#11014) Jolokia module was creating a new HTTP helper for each request, what was leading to leaks under some scenarios. Make it reuse connections.

…rface (elastic#10983)

) A number of fields in our `fields.yml` files now are `type: ip` (e.g. `source.ip`) and `type: boolean`, but the code generating index patterns does not know about these types yet and so does not add a `type` to the index pattern for those fields at all. This leads to errors in Kibana when looking at dashboards that contain references to those fields.

Migrate golang/heap to reporterV2 interface

Checks if given field conflicts with current fields. Fixes an error where `append_fields` could not add valid field.

The old docs weren't updated when 0dbb695 was merged. This corrects them, indicating how we handle 4xx and 5xx HTTP codes

Bug fix was missing an entry in CHANGELOG.next

* fix pr review link * recommend same Go version for dev, test and release. Fixes elastic#11069 * recommend cloning by SSH rather than HTTPS * Revert "recommend cloning by SSH rather than HTTPS" This reverts commit a435586.

…lastic#10828)

This change is based on elastic#10648 to migrate to golden files instead of the dynamically generated data files. This adds also support for query params to the testing framework.

…c#10945) This PR adds support for loading custom (enterprise-specific) fields to the Filebeat NetFlow input. These fields can extend and/or override fields in NetFlow V9 and IPFIX. For compatibility, the feature uses the same field definition YAML format as Logstash's netflow codec plugin. A new configuration option custom_definitions consists of a list of paths to definition files.

Currently each Metricset initialises its own logger. The selector has to be set manually. This PR moves this code to the initialisation of the Metricset, meaning each metricset has its own logger. This should reduce the code needed in each Metricset and removes errors like putting a wrong or inconsistent selectors. It's different from before where there was a global logger for all instances of the same metricset and now each metricset instance has it's own logger. This should not make a difference. As an example implementation the `system.fsstat` metricset was adjusted.

Prometheus histograms can contain buckets with keys in decimal representation. They create events with dots in the field names, what can be problematic when stored in Elasticsearch as they will create sub-objects. Add a new option to allow to store these keys in different units, so precission is kept but in a different order of magnitude.

…tic#11043)

…lastic#11046)

…rface (elastic#10852)

* Migrate golang/expvar to ReporterV2

…tic#11047)

This is intended to have a guide for users that want to test for example the Infra UI with some modules and have example containers available.

* Change number_of_objects to float in schema * Change number_of_objects type to scaled_float

In Metricbeat modules we often see the pattern that before fetching the actual data, some processing is done and checks for errors happen. If an error happened, we have 3 lines of code: * creating the error with wrap * reporting the error * logging the error By introducing the reporter interface with support for return an error I would like to eliminate the overhead and allow to directly return and error which is then reported and also logged. So far we logged the error on the Error level. I'm now wondering if we should log these errors actually on the Info level as it's normally not a misbehaving of the Beat but the service does not respond as expected. So for the operator of the Beat normally no actions are needed. As an example metricset I took php_fpm.process.

* Add support in jolokia get response for single value * Use reflect.TypeOf to check attribute and value type * Add changelog * Replace reflect by type switching * Fix indentation for comments

Closes: elastic#2821

houndci-bot · 2019-04-10T06:55:37Z

dev-tools/mage/dashboard.go

-	return dashboardCmd()
+	if kibanaURL != "" {
+		return dashboardCmd("-kibana", kibanaURL)
+	} else {


if block ends with a return statement, so drop this else and outdent its block

houndci-bot · 2019-04-10T06:55:37Z

dev-tools/mage/dashboard.go

-	return dashboardCmd()
+	if kibanaURL != "" {
+		return dashboardCmd("-kibana", kibanaURL)
+	} else {


if block ends with a return statement, so drop this else and outdent its block

houndci-bot · 2019-04-10T06:55:39Z

filebeat/config/config.go

+	OverwritePipelines bool                 `config:"overwrite_pipelines"`
+}
+
+type Registry struct {


exported type Registry should have comment or be unexported

houndci-bot · 2019-04-10T06:55:39Z

filebeat/config/config.go

+	OverwritePipelines bool                 `config:"overwrite_pipelines"`
+}
+
+type Registry struct {


exported type Registry should have comment or be unexported

houndci-bot · 2019-04-10T06:55:39Z

filebeat/config/config.go

+	OverwritePipelines bool                 `config:"overwrite_pipelines"`
+}
+
+type Registry struct {


exported type Registry should have comment or be unexported

houndci-bot · 2019-04-10T06:55:41Z

filebeat/input/log/stdin.go

@@ -44,3 +44,4 @@ func (p Pipe) Name() string               { return p.File.Name() }
 func (p Pipe) Stat() (os.FileInfo, error) { return p.File.Stat() }
 func (p Pipe) Continuable() bool          { return false }
 func (p Pipe) HasState() bool             { return false }
+func (p Pipe) Removed() bool              { return false }


exported method Pipe.Removed should have comment or be unexported

houndci-bot · 2019-04-10T06:55:41Z

filebeat/input/log/file.go


 type File struct {
 	*os.File
 }

 func (File) Continuable() bool { return true }
 func (File) HasState() bool    { return true }
+func (f File) Removed() bool   { return file.IsRemoved(f.File) }


exported method File.Removed should have comment or be unexported

houndci-bot · 2019-04-10T06:55:41Z

filebeat/input/log/stdin.go

@@ -44,3 +44,4 @@ func (p Pipe) Name() string               { return p.File.Name() }
 func (p Pipe) Stat() (os.FileInfo, error) { return p.File.Stat() }
 func (p Pipe) Continuable() bool          { return false }
 func (p Pipe) HasState() bool             { return false }
+func (p Pipe) Removed() bool              { return false }


exported method Pipe.Removed should have comment or be unexported

houndci-bot · 2019-04-10T06:55:42Z

filebeat/input/log/file.go


 type File struct {
 	*os.File
 }

 func (File) Continuable() bool { return true }
 func (File) HasState() bool    { return true }
+func (f File) Removed() bool   { return file.IsRemoved(f.File) }


exported method File.Removed should have comment or be unexported

houndci-bot · 2019-04-10T06:55:51Z

journalbeat/beater/journalbeat.go

@@ -31,6 +31,7 @@ import (
 	"github.com/elastic/beats/libbeat/logp"

 	"github.com/elastic/beats/journalbeat/config"
+	_ "github.com/elastic/beats/journalbeat/include"


a blank import should be only in a main or test package, or have a comment justifying it

houndci-bot · 2019-04-10T06:55:51Z

journalbeat/beater/journalbeat.go

@@ -31,6 +31,7 @@ import (
 	"github.com/elastic/beats/libbeat/logp"

 	"github.com/elastic/beats/journalbeat/config"
+	_ "github.com/elastic/beats/journalbeat/include"


a blank import should be only in a main or test package, or have a comment justifying it

houndci-bot · 2019-04-10T06:55:52Z

journalbeat/beater/journalbeat.go

@@ -31,6 +31,7 @@ import (
 	"github.com/elastic/beats/libbeat/logp"

 	"github.com/elastic/beats/journalbeat/config"
+	_ "github.com/elastic/beats/journalbeat/include"


a blank import should be only in a main or test package, or have a comment justifying it

houndci-bot · 2019-04-10T06:55:56Z

libbeat/cmd/export/template.go

 	"github.com/elastic/beats/libbeat/paths"
 	"github.com/elastic/beats/libbeat/template"
 )

-func GenTemplateConfigCmd(settings instance.Settings, name, idxPrefix, beatVersion string) *cobra.Command {
+func GenTemplateConfigCmd(settings instance.Settings) *cobra.Command {


exported function GenTemplateConfigCmd should have comment or be unexported

houndci-bot · 2019-04-10T06:55:56Z

libbeat/cmd/export/template.go

 	"github.com/elastic/beats/libbeat/paths"
 	"github.com/elastic/beats/libbeat/template"
 )

-func GenTemplateConfigCmd(settings instance.Settings, name, idxPrefix, beatVersion string) *cobra.Command {
+func GenTemplateConfigCmd(settings instance.Settings) *cobra.Command {


exported function GenTemplateConfigCmd should have comment or be unexported

houndci-bot · 2019-04-10T06:55:56Z

libbeat/cmd/export/template.go

 	"github.com/elastic/beats/libbeat/paths"
 	"github.com/elastic/beats/libbeat/template"
 )

-func GenTemplateConfigCmd(settings instance.Settings, name, idxPrefix, beatVersion string) *cobra.Command {
+func GenTemplateConfigCmd(settings instance.Settings) *cobra.Command {


exported function GenTemplateConfigCmd should have comment or be unexported

houndci-bot · 2019-04-10T06:55:58Z

libbeat/cmd/test/output.go

 	"github.com/elastic/beats/libbeat/outputs"
 	"github.com/elastic/beats/libbeat/testing"
 )

-func GenTestOutputCmd(name, beatVersion string) *cobra.Command {
+func GenTestOutputCmd(settings instance.Settings) *cobra.Command {


exported function GenTestOutputCmd should have comment or be unexported

houndci-bot · 2019-04-10T06:55:58Z

libbeat/cmd/test/config.go

@@ -27,18 +27,18 @@ import (
 	"github.com/elastic/beats/libbeat/cmd/instance"
 )

-func GenTestConfigCmd(name, version string, beatCreator beat.Creator) *cobra.Command {
+func GenTestConfigCmd(settings instance.Settings, beatCreator beat.Creator) *cobra.Command {


exported function GenTestConfigCmd should have comment or be unexported

houndci-bot · 2019-04-10T06:55:58Z

libbeat/common/config.go

+	return c.access().Remove(name, idx, configOpts...)
+}
+
+func (c *Config) Has(name string, idx int) (bool, error) {


exported method Config.Has should have comment or be unexported

houndci-bot · 2019-04-10T06:55:58Z

libbeat/common/config.go

@@ -188,6 +188,14 @@ func (c *Config) PathOf(field string) string {
 	return c.access().PathOf(field, ".")
 }

+func (c *Config) Remove(name string, idx int) (bool, error) {


exported method Config.Remove should have comment or be unexported

houndci-bot · 2019-04-10T06:55:59Z

libbeat/cmd/test/output.go

 	"github.com/elastic/beats/libbeat/outputs"
 	"github.com/elastic/beats/libbeat/testing"
 )

-func GenTestOutputCmd(name, beatVersion string) *cobra.Command {
+func GenTestOutputCmd(settings instance.Settings) *cobra.Command {


exported function GenTestOutputCmd should have comment or be unexported

houndci-bot · 2019-04-10T06:55:59Z

libbeat/cmd/test/config.go

@@ -27,18 +27,18 @@ import (
 	"github.com/elastic/beats/libbeat/cmd/instance"
 )

-func GenTestConfigCmd(name, version string, beatCreator beat.Creator) *cobra.Command {
+func GenTestConfigCmd(settings instance.Settings, beatCreator beat.Creator) *cobra.Command {


exported function GenTestConfigCmd should have comment or be unexported

houndci-bot · 2019-04-10T06:56:00Z

libbeat/common/mapval/is_defs.go

+	})
+}
+
+func ScopedIsUnique() UniqScopeTracker {


exported function ScopedIsUnique should have comment or be unexported

houndci-bot · 2019-04-10T06:56:00Z

libbeat/common/config.go

+	return c.access().Remove(name, idx, configOpts...)
+}
+
+func (c *Config) Has(name string, idx int) (bool, error) {


exported method Config.Has should have comment or be unexported

houndci-bot · 2019-04-10T06:56:00Z

libbeat/common/config.go

@@ -188,6 +188,14 @@ func (c *Config) PathOf(field string) string {
 	return c.access().PathOf(field, ".")
 }

+func (c *Config) Remove(name string, idx int) (bool, error) {


exported method Config.Remove should have comment or be unexported

cachedout · 2019-04-10T06:56:30Z

Guh. That rebase went horribly wrong.

houndci-bot · 2019-04-10T06:57:01Z

libbeat/mock/mockbeat.go

@@ -30,6 +31,8 @@ import (
 var Version = "9.9.9"
 var Name = "mockbeat"

+var Settings = instance.Settings{Name: Name, Version: Version}


exported var Settings should have comment or be unexported

houndci-bot · 2019-04-10T06:57:01Z

libbeat/mapping/field.go

+	return false
+}
+
+// Recursively generates the correct key based on the dots


comment on exported function GenerateKey should be of the form "GenerateKey ..."

houndci-bot · 2019-04-10T06:57:02Z

libbeat/mapping/field.go

+	return nil
+}
+
+func LoadFieldsYaml(path string) (Fields, error) {


exported function LoadFieldsYaml should have comment or be unexported

houndci-bot · 2019-04-10T06:57:02Z

libbeat/mapping/field.go

+
+type DynamicType struct{ Value interface{} }
+
+func (d *DynamicType) Unpack(s string) error {


exported method DynamicType.Unpack should have comment or be unexported

houndci-bot · 2019-04-10T06:57:02Z

libbeat/mapping/field.go

+	Value      string `config:"value"`
+}
+
+type DynamicType struct{ Value interface{} }


exported type DynamicType should have comment or be unexported

houndci-bot · 2019-04-10T06:57:03Z

libbeat/mapping/field.go

+//  -ElasticSearch Template
+//  -Kibana Index Pattern
+
+type Fields []Field


exported type Fields should have comment or be unexported

houndci-bot · 2019-04-10T06:57:03Z

libbeat/libbeat.go

@@ -24,7 +24,7 @@ import (
 	"github.com/elastic/beats/libbeat/mock"
 )

-var RootCmd = cmd.GenRootCmd(mock.Name, mock.Version, mock.New)
+var RootCmd = cmd.GenRootCmdWithSettings(mock.New, mock.Settings)


exported var RootCmd should have comment or be unexported

houndci-bot · 2019-04-10T06:57:04Z

libbeat/kibana/client.go

@@ -217,32 +217,24 @@ func (client *Client) readVersion() error {

 	code, result, err := client.Connection.Request("GET", "/api/status", nil, nil, nil)
 	if err != nil || code >= 400 {
-		return fmt.Errorf("HTTP GET request to /api/status fails: %v. Response: %s.",
-			err, truncateString(result))
+		return fmt.Errorf("HTTP GET request to %s/api/status fails: %v. Response: %s.",


error strings should not be capitalized or end with punctuation or a newline

houndci-bot · 2019-04-10T06:57:04Z

libbeat/idxmgmt/ilm/error.go

+}
+
+var (
+	ErrESVersionNotSupported = errors.New("ILM is not supported by the Elasticsearch version in use")


exported var ErrESVersionNotSupported should have comment or be unexported

houndci-bot · 2019-04-10T06:57:04Z

libbeat/dashboards/dashboards.go

-		} else {
-			importVia = useKibana
-		}
+		return errors.New("kibana configuration missing for loading dashboards.")


error strings should not be capitalized or end with punctuation or a newline

houndci-bot · 2019-04-10T06:57:16Z

libbeat/publisher/processing/default.go

+
+// WithBeatMeta adds beat meta information as builtin fields to a processing pipeline.
+// The `key` parameter defines the field to be used.
+func WithBeatMeta(key string) modifier {


exported func WithBeatMeta returns unexported type processing.modifier, which can be annoying to use

houndci-bot · 2019-04-10T06:57:16Z

libbeat/publisher/processing/default.go

+}
+
+// WithECS modifier adds `ecs.version` builtin fields to a processing pipeline.
+var WithECS modifier = WithFields(common.MapStr{


should omit type modifier from declaration of var WithECS; it will be inferred from the right-hand side

houndci-bot · 2019-04-10T06:57:16Z

libbeat/publisher/processing/default.go

+}
+
+// WithFields creates a modifier with the given default builtin fields.
+func WithFields(fields common.MapStr) modifier {


exported func WithFields returns unexported type processing.modifier, which can be annoying to use

houndci-bot · 2019-04-10T06:58:16Z

metricbeat/module/ceph/cluster_status/cluster_status_test.go

@@ -96,22 +100,22 @@ func TestFetchEventContents(t *testing.T) {
 	assert.EqualValues(t, 2872860672, pgInfo["used_bytes"])

 	//check pg_state info
-	pg_stateInfo := events[1]["pg_state"].(common.MapStr)
+	pg_stateInfo := events[1].MetricSetFields["pg_state"].(common.MapStr)


don't use underscores in Go names; var pg_stateInfo should be pgStateInfo

houndci-bot · 2019-04-10T06:58:16Z

metricbeat/module/prometheus/collector/collector.go

 	}, nil
 }

-func (m *MetricSet) Fetch() ([]common.MapStr, error) {
+func (m *MetricSet) Fetch(reporter mb.ReporterV2) {


exported method MetricSet.Fetch should have comment or be unexported

houndci-bot · 2019-04-10T06:58:17Z

metricbeat/module/ceph/cluster_status/cluster_status_test.go

@@ -96,22 +100,22 @@ func TestFetchEventContents(t *testing.T) {
 	assert.EqualValues(t, 2872860672, pgInfo["used_bytes"])

 	//check pg_state info
-	pg_stateInfo := events[1]["pg_state"].(common.MapStr)
+	pg_stateInfo := events[1].MetricSetFields["pg_state"].(common.MapStr)


don't use underscores in Go names; var pg_stateInfo should be pgStateInfo

houndci-bot · 2019-04-10T06:58:18Z

metricbeat/module/prometheus/collector/collector.go

 	}, nil
 }

-func (m *MetricSet) Fetch() ([]common.MapStr, error) {
+func (m *MetricSet) Fetch(reporter mb.ReporterV2) {


exported method MetricSet.Fetch should have comment or be unexported

houndci-bot · 2019-04-10T06:58:18Z

metricbeat/module/ceph/cluster_status/cluster_status_test.go

@@ -96,22 +100,22 @@ func TestFetchEventContents(t *testing.T) {
 	assert.EqualValues(t, 2872860672, pgInfo["used_bytes"])

 	//check pg_state info
-	pg_stateInfo := events[1]["pg_state"].(common.MapStr)
+	pg_stateInfo := events[1].MetricSetFields["pg_state"].(common.MapStr)


don't use underscores in Go names; var pg_stateInfo should be pgStateInfo

houndci-bot · 2019-04-10T06:58:19Z

metricbeat/module/prometheus/collector/collector.go

 	}, nil
 }

-func (m *MetricSet) Fetch() ([]common.MapStr, error) {
+func (m *MetricSet) Fetch(reporter mb.ReporterV2) {


exported method MetricSet.Fetch should have comment or be unexported

houndci-bot · 2019-04-10T06:58:28Z

x-pack/auditbeat/module/system/login/login.go

+}
+
+// LoginRecord represents a login record.
+type LoginRecord struct {


type name will be used as login.LoginRecord by other packages, and that stutters; consider calling this Record

houndci-bot · 2019-04-10T06:58:28Z

x-pack/auditbeat/module/system/login/utmp_c.go

+
+	UT_LINESIZE = 32
+	UT_NAMESIZE = 32
+	UT_HOSTSIZE = 256


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:28Z

x-pack/auditbeat/module/system/login/utmp_c.go

+	ACCOUNTING    UtType = 9
+
+	UT_LINESIZE = 32
+	UT_NAMESIZE = 32


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:29Z

x-pack/auditbeat/module/system/login/utmp_c.go

+	DEAD_PROCESS  UtType = 8
+	ACCOUNTING    UtType = 9
+
+	UT_LINESIZE = 32


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:29Z

x-pack/auditbeat/module/system/login/utmp_c.go

+	INIT_PROCESS  UtType = 5
+	LOGIN_PROCESS UtType = 6
+	USER_PROCESS  UtType = 7
+	DEAD_PROCESS  UtType = 8


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:29Z

x-pack/auditbeat/module/system/login/utmp_c.go

+	OLD_TIME      UtType = 4
+	INIT_PROCESS  UtType = 5
+	LOGIN_PROCESS UtType = 6
+	USER_PROCESS  UtType = 7


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:30Z

x-pack/auditbeat/module/system/login/utmp_c.go

+	RUN_LVL       UtType = 1
+	BOOT_TIME     UtType = 2
+	NEW_TIME      UtType = 3
+	OLD_TIME      UtType = 4


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:30Z

x-pack/auditbeat/module/system/login/utmp_c.go

+	EMPTY         UtType = 0
+	RUN_LVL       UtType = 1
+	BOOT_TIME     UtType = 2
+	NEW_TIME      UtType = 3


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:30Z

x-pack/auditbeat/module/system/login/utmp_c.go

+const (
+	EMPTY         UtType = 0
+	RUN_LVL       UtType = 1
+	BOOT_TIME     UtType = 2


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:30Z

x-pack/auditbeat/module/system/login/utmp_c.go

+// Possible values for UtType.
+const (
+	EMPTY         UtType = 0
+	RUN_LVL       UtType = 1


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T06:58:31Z

x-pack/auditbeat/module/system/login/login.go

+}
+
+// LoginRecord represents a login record.
+type LoginRecord struct {


type name will be used as login.LoginRecord by other packages, and that stutters; consider calling this Record

houndci-bot · 2019-04-10T07:00:45Z

x-pack/metricbeat/module/mssql/transaction_log/data_integration_test.go

+// or more contributor license agreements. Licensed under the Elastic License;
+// you may not use this file except in compliance with the Elastic License.
+
+package transaction_log


don't use an underscore in package name

houndci-bot · 2019-04-10T07:00:45Z

x-pack/metricbeat/module/aws/s3_request/s3_request_integration_test.go

+
+// +build integration
+
+package s3_request


don't use an underscore in package name

houndci-bot · 2019-04-10T07:00:45Z

x-pack/metricbeat/module/aws/s3_request/s3_request.go

+// or more contributor license agreements. Licensed under the Elastic License;
+// you may not use this file except in compliance with the Elastic License.
+
+package s3_request


don't use an underscore in package name

houndci-bot · 2019-04-10T07:00:45Z

x-pack/metricbeat/module/aws/s3_request/data.go

+// or more contributor license agreements. Licensed under the Elastic License;
+// you may not use this file except in compliance with the Elastic License.
+
+package s3_request


don't use an underscore in package name

houndci-bot · 2019-04-10T07:00:46Z

x-pack/metricbeat/module/aws/s3_daily_storage/s3_daily_storage_integration_test.go

+
+// +build integration
+
+package s3_daily_storage


don't use an underscore in package name

houndci-bot · 2019-04-10T07:00:48Z

x-pack/filebeat/input/netflow/decoder/fields/types.go

@@ -322,6 +323,34 @@ func (u UnsupportedDecoder) Decode(data []byte) (interface{}, error) {

 var _ Decoder = (*UnsupportedDecoder)(nil)

+type ACLIDDecoder struct{}


exported type ACLIDDecoder should have comment or be unexported

houndci-bot · 2019-04-10T07:00:48Z

x-pack/filebeat/input/netflow/decoder/fields/field.go

@@ -20,12 +20,20 @@ type Field struct {

 type FieldDict map[Key]*Field

-func RegisterFields(dict FieldDict) error {
+func RegisterGlobalFields(dict FieldDict) error {


exported function RegisterGlobalFields should have comment or be unexported

houndci-bot · 2019-04-10T07:00:48Z

x-pack/filebeat/input/netflow/decoder/fields/field.go

@@ -6,7 +6,7 @@ package fields

 import "fmt"

-var Fields = FieldDict{}
+var GlobalFields = FieldDict{}


exported var GlobalFields should have comment or be unexported

houndci-bot · 2019-04-10T07:00:48Z

x-pack/auditbeat/module/system/user/user.go

@@ -170,6 +172,15 @@ func (user User) toMapStr() common.MapStr {
 	return evt
 }

+// entityID creates an ID that uniquely identifies this user across machines.
+func (u User) entityID(hostID string) string {


receiver name u should be consistent with previous receiver name user for User

houndci-bot · 2019-04-10T07:00:49Z

x-pack/auditbeat/module/system/system.go

+}
+
+// SystemMetricSet extends the Metricbeat BaseMetricSet.
+type SystemMetricSet struct {


type name will be used as system.SystemMetricSet by other packages, and that stutters; consider calling this MetricSet

houndci-bot · 2019-04-10T07:02:10Z

x-pack/auditbeat/module/system/system.go

+
+// SystemModule extends the Metricbeat BaseModule. The purpose is to allow
+// configuring sub-modules as "datasets" rather than "metricsets".
+type SystemModule struct {


type name will be used as system.SystemModule by other packages, and that stutters; consider calling this Module

houndci-bot · 2019-04-10T07:02:11Z

x-pack/auditbeat/module/system/system.go

+}
+
+// SystemModuleConfig contains the configuration specific to the system module.
+type SystemModuleConfig struct {


type name will be used as system.SystemModuleConfig by other packages, and that stutters; consider calling this ModuleConfig

houndci-bot · 2019-04-10T07:02:11Z

x-pack/auditbeat/module/system/package/rpm_linux.go

+	RPMTAG_URL         = 1020
+	RPMTAG_ARCH        = 1022
+	RPMTAG_SIZE        = 1009
+	RPMTAG_INSTALLTIME = 1008


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T07:02:11Z

x-pack/auditbeat/module/system/package/rpm_linux.go

+	RPMTAG_LICENSE     = 1014
+	RPMTAG_URL         = 1020
+	RPMTAG_ARCH        = 1022
+	RPMTAG_SIZE        = 1009


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T07:02:12Z

x-pack/auditbeat/module/system/package/rpm_linux.go

+	RPMTAG_SUMMARY     = 1004
+	RPMTAG_LICENSE     = 1014
+	RPMTAG_URL         = 1020
+	RPMTAG_ARCH        = 1022


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T07:02:13Z

x-pack/auditbeat/module/system/package/rpm_linux.go

+const (
+	RPMTAG_NAME        = 1000
+	RPMTAG_VERSION     = 1001
+	RPMTAG_RELEASE     = 1002


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T07:02:13Z

x-pack/auditbeat/module/system/package/rpm_linux.go

+// Constants in sync with /usr/include/rpm/rpmtag.h
+const (
+	RPMTAG_NAME        = 1000
+	RPMTAG_VERSION     = 1001


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T07:02:13Z

x-pack/auditbeat/module/system/package/rpm_linux.go

+
+// Constants in sync with /usr/include/rpm/rpmtag.h
+const (
+	RPMTAG_NAME        = 1000


don't use ALL_CAPS in Go names; use CamelCase

houndci-bot · 2019-04-10T07:02:14Z

x-pack/metricbeat/module/mssql/transaction_log/transaction_log_integration_test.go

+
+// +build integration
+
+package transaction_log


don't use an underscore in package name

houndci-bot · 2019-04-10T07:02:14Z

x-pack/metricbeat/module/mssql/transaction_log/transaction_log.go

+// or more contributor license agreements. Licensed under the Elastic License;
+// you may not use this file except in compliance with the Elastic License.
+
+package transaction_log


don't use an underscore in package name

cachedout requested a review from a team as a code owner January 4, 2019 23:13

urso requested a review from ph January 5, 2019 15:05

ph suggested changes Jan 9, 2019

View reviewed changes

ph added enhancement Filebeat Filebeat labels Jan 9, 2019

Carmelo Mirko Musumeci and others added 23 commits March 5, 2019 14:29

Fix for not reusable http client leading to connection leaks in Jolo…

288a76c

…kia module (elastic#11014) Jolokia module was creating a new HTTP helper for each request, what was leading to leaks under some scenarios. Make it reuse connections.

[Metricbeat] Migrate Memcached stats Metricset to use ReporterV2 inte…

6951584

…rface (elastic#10983)

[Metricbeat] Migrate heap to reporterV2 interface (elastic#11074)

0a858b5

Migrate golang/heap to reporterV2 interface

Allow ConcatFields for nodes of type object (elastic#10959)

527fbd4

Checks if given field conflicts with current fields. Fixes an error where `append_fields` could not add valid field.

[Uptime] Fix docs for HTTP status checks (elastic#11073)

c313482

The old docs weren't updated when 0dbb695 was merged. This corrects them, indicating how we handle 4xx and 5xx HTTP codes

Update changelog for elastic#10950 (elastic#11018)

b6c05a2

Bug fix was missing an entry in CHANGELOG.next

Beats docs - Contributing improvements (elastic#11072)

fbc2dda

* fix pr review link * recommend same Go version for dev, test and release. Fixes elastic#11069 * recommend cloning by SSH rather than HTTPS * Revert "recommend cloning by SSH rather than HTTPS" This reverts commit a435586.

Migrate PostgresSQL activity metricset to use ReporterV2 interface (e…

aac95c1

…lastic#10828)

[Metricbeat] Add http endpoint tests for php_fpm module (elastic#11088)

af9e048

This change is based on elastic#10648 to migrate to golden files instead of the dynamically generated data files. This adds also support for query params to the testing framework.

[Metricbeat] Migrate Couchdb server to use ReporterV2 interface (elas…

087c880

…tic#11043)

[Metricbeat] Migrate Couchbase cluster to use ReporterV2 interface (e…

2229970

…lastic#11046)

[Metricbeat] Migrate MongoDB dbstats Metricset to use ReporterV2 inte…

360fe0d

…rface (elastic#10852)

Migrate golang/expvar to ReporterV2 (elastic#11103)

1e9f8f6

* Migrate golang/expvar to ReporterV2

[Metricbeat] Migrate Couchbase node to use ReporterV2 interface (elas…

5390692

…tic#11047)

[Metricbeat] Add docs about manual module testing (elastic#10724)

b57bcda

This is intended to have a guide for users that want to test for example the Infra UI with some modules and have example containers available.

Change number_of_objects to float in schema (elastic#11030)

6118607

* Change number_of_objects to float in schema * Change number_of_objects type to scaled_float

Add support in jolokia get response for single value (elastic#11075)

c238ea2

* Add support in jolokia get response for single value * Use reflect.TypeOf to check attribute and value type * Add changelog * Replace reflect by type switching * Fix indentation for comments

Fix flows timeout setting error message (elastic#11050)

71fb58b

Closes: elastic#2821

houndci-bot reviewed Apr 10, 2019

View reviewed changes

cachedout closed this Apr 10, 2019

houndci-bot reviewed Apr 10, 2019

View reviewed changes

cachedout mentioned this pull request Apr 10, 2019

Add option to set rcv_buffer for UDP inputs #11739

Merged

houndci-bot reviewed Apr 10, 2019

View reviewed changes

ycombinator mentioned this pull request Apr 26, 2019

[7.0] Collect and index CCR auto-follow stats (#11574) #11958

Merged

ycombinator mentioned this pull request Jul 19, 2019

[6.8] Remove cluster_name from under cluster_stats field (#11654) #12985

Merged


		type DynamicType struct{ Value interface{} }

		func (d *DynamicType) Unpack(s string) error {

		@@ -322,6 +323,34 @@ func (u UnsupportedDecoder) Decode(data []byte) (interface{}, error) {

		var _ Decoder = (*UnsupportedDecoder)(nil)

		type ACLIDDecoder struct{}

Add option to set rcv_buffer for UDP inputs #9906

Add option to set rcv_buffer for UDP inputs #9906

Conversation

cachedout commented Jan 4, 2019

elasticmachine commented Jan 4, 2019

ph left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ph commented Jan 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cachedout commented Apr 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ph commented Jan 9, 2019 •

edited

Loading