Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-sysinfo #9920

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Update go-sysinfo #9920

merged 2 commits into from
Jan 8, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Jan 7, 2019

Updates go-sysinfo to its current master. This will automatically populate the host.id on macOS if the add_host_processor is being used (the default in 7.0).

It also adds some functionality for processes that is needed in the Auditbeat system module.

@cwurm cwurm added review needs_backport PR is waiting to be backported to other branches. labels Jan 7, 2019
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please rebase as soon as #9942 is merged to make sure CI goes green.

@cwurm cwurm merged commit ae290b4 into elastic:master Jan 8, 2019
cwurm pushed a commit to cwurm/beats that referenced this pull request Jan 8, 2019
Updates go-sysinfo to its current master. This will automatically populate the host.id on macOS if the add_host_processor is being used (the default in 7.0).

(cherry picked from commit ae290b4)
@cwurm cwurm added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 8, 2019
cwurm pushed a commit to cwurm/beats that referenced this pull request Jan 8, 2019
Updates go-sysinfo to its current master. This will automatically populate the host.id on macOS if the add_host_processor is being used (the default in 7.0).

(cherry picked from commit ae290b4)
@cwurm cwurm added the v6.6.0 label Jan 8, 2019
@cwurm cwurm deleted the update_go_sysinfo branch January 8, 2019 14:44
@andrewkroh
Copy link
Member

It would be good to have an a bugfix entry in the changelog saying that this fixes a registry handle leak on Windows.

@cwurm
Copy link
Contributor Author

cwurm commented Jan 9, 2019

It would be good to have an a bugfix entry in the changelog saying that this fixes a registry handle leak on Windows.

+1 - #9970

@cwurm cwurm removed the v6.7.0 label Jan 9, 2019
cwurm pushed a commit that referenced this pull request Jan 10, 2019
cwurm pushed a commit that referenced this pull request Jan 10, 2019
Cherry-pick of PR #9920 to 6.x branch. Original message: 

Updates `go-sysinfo` to its current master. This will automatically populate the `host.id` on macOS if the `add_host_processor` is being used (the default in 7.0).

It also adds some functionality for processes that is needed in the Auditbeat system module.

Also includes a bugfix that correctly closes two handles.
cwurm pushed a commit that referenced this pull request Jan 10, 2019
Cherry-pick of PR #9920 to 6.6 branch. Original message: 

Updates `go-sysinfo` to its current master. This will automatically populate the `host.id` on macOS if the `add_host_processor` is being used (the default in 7.0).

It also adds some functionality for processes that is needed in the Auditbeat system module.

Also includes a bugfix that correctly closes two handles.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Cherry-pick of PR elastic#9920 to 6.6 branch. Original message: 

Updates `go-sysinfo` to its current master. This will automatically populate the `host.id` on macOS if the `add_host_processor` is being used (the default in 7.0).

It also adds some functionality for processes that is needed in the Auditbeat system module.

Also includes a bugfix that correctly closes two handles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants