-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-sysinfo #9920
Update go-sysinfo #9920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But please rebase as soon as #9942 is merged to make sure CI goes green.
082d5d1
to
9214b05
Compare
Updates go-sysinfo to its current master. This will automatically populate the host.id on macOS if the add_host_processor is being used (the default in 7.0). (cherry picked from commit ae290b4)
Updates go-sysinfo to its current master. This will automatically populate the host.id on macOS if the add_host_processor is being used (the default in 7.0). (cherry picked from commit ae290b4)
It would be good to have an a bugfix entry in the changelog saying that this fixes a registry handle leak on Windows. |
+1 - #9970 |
Cherry-pick of PR #9920 to 6.x branch. Original message: Updates `go-sysinfo` to its current master. This will automatically populate the `host.id` on macOS if the `add_host_processor` is being used (the default in 7.0). It also adds some functionality for processes that is needed in the Auditbeat system module. Also includes a bugfix that correctly closes two handles.
Cherry-pick of PR #9920 to 6.6 branch. Original message: Updates `go-sysinfo` to its current master. This will automatically populate the `host.id` on macOS if the `add_host_processor` is being used (the default in 7.0). It also adds some functionality for processes that is needed in the Auditbeat system module. Also includes a bugfix that correctly closes two handles.
Cherry-pick of PR elastic#9920 to 6.6 branch. Original message: Updates `go-sysinfo` to its current master. This will automatically populate the `host.id` on macOS if the `add_host_processor` is being used (the default in 7.0). It also adds some functionality for processes that is needed in the Auditbeat system module. Also includes a bugfix that correctly closes two handles.
Updates
go-sysinfo
to its current master. This will automatically populate thehost.id
on macOS if theadd_host_processor
is being used (the default in 7.0).It also adds some functionality for processes that is needed in the Auditbeat system module.