Store transport keys and certificates in a single shared secret. #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkvoll
force-pushed
the
no-pod-specific-transport-secret
branch
from
26d16ca to
0b207ff
Compare
nkvoll
changed the title
nkvoll
force-pushed
the
no-pod-specific-transport-secret
branch
from
0b207ff to
505f7b0
Compare
sebgl
approved these changes
Jul 5, 2019
operators/pkg/controller/elasticsearch/certificates/transport/pod_secret.go
Outdated
Show resolved
Hide resolved
operators/pkg/controller/elasticsearch/certificates/transport/reconcile.go
Outdated
Show resolved
Hide resolved
operators/pkg/controller/elasticsearch/certificates/transport/transport_fixtures_test.go
Show resolved
Hide resolved
operators/pkg/controller/elasticsearch/initcontainer/prepare_fs_script.go
Outdated
Show resolved
Hide resolved
operators/pkg/controller/elasticsearch/initcontainer/prepare_fs_script.go
Outdated
Show resolved
Hide resolved
operators/pkg/controller/elasticsearch/certificates/transport/pod_secret_test.go
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| if len(keysToPrune) > 0 { | ||
| log.Info("Pruning keys from certificates secret", "keys", keysToPrune) |
There was a problem hiding this comment.
Would be nice to have this unit tested.
|
Re the unit test for pruning, I wonder if it will be sufficiently different with StatefulSets it makes more sense to cover it there (note the method in question is also currently un-tested as it's going to be refactored come StatefulSet changes) |
|
I'm fine with keeping some unit tests for later (let's try not to forget them though) since we'll be breaking a lot of stuff. |
This facilitates a move to StatefulSets where the mounted secrets must be the same between all the Pods in the same StatefulSet
nkvoll
force-pushed
the
no-pod-specific-transport-secret
branch
from
f97e775 to
3b24cd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This facilitates a move to StatefulSets where the mounted secrets must be the same between all the Pods in the same StatefulSet.