Allow webhook cert directory to be overridden #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set a new `--webhook-cert-dir` flag that allows overriding the path to
the webhook certificates, most likely mounted from a Secret.
It's intended to be used this way:
```
args: ["manager", "--operator-roles", "all",
"--webhook-cert-dir=/tmp/whatever"]
```
(or by overriding the equivalent environment variable)
And the corresponding secret mount:
```
volumeMounts:
- mountPath: /tmp/whatever
name: cert
readOnly: true
```
sebgl
changed the title
thbkrkr
reviewed
Jan 28, 2020
anyasabo
reviewed
Jan 28, 2020
| @@ -26,7 +26,8 @@ ECK can be configured using either command line flags or environment variables. | |||
| |operator-namespace |"" |Namespace the operator runs in. Required. | |||
| |operator-roles |all |Roles this operator should assume. Valid values are `namespace`, `global`, `webhook` or `all`. Accepts multiple comma separated values. | |||
| |webhook-pods-label |"" |Label used to select pods running the webhook server. | |||
| |webhook-secret |"" | Kubernetes secret containing the webhook certificates. | |||
| |webhook-secret |"" | K8s secret mounted into the path designated by webhook-cert-dir to be used for webhook certificates. | |||
| |webhook-cert-dir |"{TempDir}/k8s-webhook-server/serving-certs" |Path to the directory that contains the webhook server key and certificate. | |||
There was a problem hiding this comment.
I was curious if the leading space differences in the last item (| K8s secret mounted vs |Path to the directory) changes how it renders. It looks like it does not so I don't think we need to be nitpicky here
anyasabo
approved these changes
Jan 28, 2020
thbkrkr
reviewed
Jan 29, 2020
thbkrkr
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a new
--webhook-cert-dirflag that allows overriding the path tothe webhook certificates, most likely mounted from a Secret.
It's intended to be used this way:
(or by overriding the equivalent environment variable)
And the corresponding secret mount:
Fixes #2463.