Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfigRef to Beat CRD #3210

Merged
merged 4 commits into from
Jun 16, 2020
Merged

Add ConfigRef to Beat CRD #3210

merged 4 commits into from
Jun 16, 2020

Conversation

david-kow
Copy link
Contributor

@david-kow david-kow commented Jun 10, 2020 •
edited
Loading

This PR adds configRef field to Beat CRD, resolves #3203.

This enables two use cases:

  • user is storing Beat config in a Secret and wants to use it
  • user wants to deploy default config, but have a Secret created for editing later (this currently only works for metricbeat and filebeat as we have no defaults for others)

@david-kow david-kow added >feature Adds or discusses adding a feature to the product :beats labels Jun 10, 2020
barkbay
barkbay reviewed Jun 11, 2020
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a first review, left a few nitpicks, I'll take the time to run it on a sample.

Also I was wondering if we should update the samples to mention this feature.

pkg/apis/beat/v1beta1/beat_types.go Outdated Show resolved Hide resolved
pkg/apis/beat/v1beta1/beat_types.go Outdated Show resolved Hide resolved
pkg/controller/beat/common/config.go Outdated Show resolved Hide resolved
barkbay
barkbay reviewed Jun 11, 2020
View reviewed changes
pkg/controller/beat/common/config.go Outdated Show resolved Hide resolved
pkg/controller/beat/common/config.go Outdated Show resolved Hide resolved
@david-kow david-kow requested a review from barkbay June 11, 2020 14:21
@david-kow david-kow force-pushed the beat_crd_configref_defaults branch 2 times, most recently from 9fc5dfc to 829fcd0 Compare June 15, 2020 23:48
@david-kow david-kow requested a review from sebgl June 16, 2020 00:40
barkbay
barkbay reviewed Jun 16, 2020
View reviewed changes
pkg/controller/beat/common/config.go Outdated Show resolved Hide resolved
pkg/controller/beat/common/config.go Outdated Show resolved Hide resolved
pkg/controller/beat/common/config.go Outdated Show resolved Hide resolved
@david-kow david-kow force-pushed the beat_crd_configref_defaults branch from 829fcd0 to abd3708 Compare June 16, 2020 12:15
sebgl
sebgl approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/controller/beat/common/config.go Outdated Show resolved Hide resolved
pkg/controller/beat/common/config.go Outdated Show resolved Hide resolved
@david-kow david-kow merged commit 29d7abc into elastic:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barkbay barkbay barkbay left review comments

@sebgl sebgl sebgl approved these changes

Assignees
No one assigned
Labels
>feature Adds or discusses adding a feature to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configRef to Beat CRD
3 participants
@david-kow @barkbay @sebgl