Isolate operator from http service misconfiguration - Use internal service #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use the internally managed service, which does not apply the spec's selector defined within the CRD when creating the service to avoid a user misconfiguring the selectors. Added a unit test to ensure that the service doesn't inherit it's CRD spec's selector.
|
Question for discussion: In this solution, would we want to only target the master nodes, instead of all nodes? |
|
From a discussion with members of the Elasticsearch team, they note that these ES calls optimally should not be directed at the masters: "/_cat/shards?format=json" relevant information from discussion |
|
run full pr build |
pebrc
reviewed
Jan 14, 2022
Update comments
pebrc
reviewed
Jan 14, 2022
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
…rvice (elastic#5211) * When constructing the Elasticsearch client for internal operator use, use the internally managed service, which does not apply the spec's selector defined within the CRD when creating the service to avoid a user misconfiguring the selectors. Added a unit test to ensure that the service doesn't inherit it's CRD spec's selector. * Set all aspects of internal service explicitly. Update comments * remove setting ipfamilies * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #5005 has been open, with active discussion for quite some time, I thought it would be useful to go back to the beginning and look at what we were trying to accomplish in the original issue #4394, which was ensuring that the user can't misconfigure the operator so it can't manage an Elasticsearch cluster. In the original PR, we chose to go the route of choosing a random pod for communication between the operator, and the ES cluster, which caused its own set of concerns once we both saw the implementation, and tested the consequences of the implementation.
This PR shows the changes that would be applied to the operator if we chose the other route, which was managing an internal service that does not inherit the selector defined within the custom resources's spec. This will, at least, give us more information to make a better decision about which route we believe is best to move either solution forward to resolving the initial issue.
To be clear, only one of #5005, or this issue (or none if we so choose) will be merged. The other will be closed as is.
resolves #4394