Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle resource conflict while updating status in association reconciler #5337

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Feb 7, 2022

This commit removes reconciliation errors that occur when the association controller updats the association's parent resource:

2022-02-07T10:24:27.808+0100    ERROR   manager.eck-operator.controller.beat-kibana-association-controller  
  Reconciler error {
    "service.version": "2.1.0-SNAPSHOT+48044437",
    "name": "filebeat",
    "namespace": "default",
    "error": "Operation cannot be fulfilled on beats.beat.k8s.elastic.co \"filebeat\": the object has been modified; 
              please apply your changes to the latest version and try again"
}

Similar to #824.

@thbkrkr thbkrkr added >enhancement Enhancement of existing functionality v2.1.0 labels Feb 7, 2022
@thbkrkr thbkrkr merged commit a278f48 into elastic:main Feb 14, 2022
@barkbay
Copy link
Contributor

barkbay commented Feb 15, 2022

@miriam-eid I think this is the fix for #4897

@thbkrkr
Copy link
Contributor Author

thbkrkr commented Feb 15, 2022

@barkbay This silences errors coming from the xx-yy-association-controller, not the beat-controller, so #4897 still seems relevant.

@barkbay
Copy link
Contributor

barkbay commented Feb 15, 2022

#4897 still seems relevant

While working on #4897 we (with @miriam-eid ) discovered that *beat-controller errors were actually already fixed (I can't remember in which pr/release). However, there were still some errors from *-association-controller which are now fixed.

thbkrkr added a commit to thbkrkr/cloud-on-k8s that referenced this pull request Feb 16, 2022
thbkrkr added a commit to thbkrkr/cloud-on-k8s that referenced this pull request Feb 16, 2022
@thbkrkr thbkrkr deleted the handle-conflict-on-status-update-in-assoc-controllers branch March 22, 2022 16:36
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants