Avoid unnecessary DELETE calls to manage legacy transport secret #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naemono
approved these changes
Mar 10, 2022
| }, | ||
| var secret corev1.Secret | ||
| // do a GET from the cache first before attempting a DElETE that hits the API server | ||
| err := client.Get(context.Background(), types.NamespacedName{Namespace: es.Namespace, Name: esv1.LegacyTransportCertsSecretSuffix(es.Name)}, &secret) |
There was a problem hiding this comment.
Question, not an issue, but why do we use context.Background() throughout the codebase for kubernetes client.* calls instead of something with a default timeout?
There was a problem hiding this comment.
I think that's a valid question maybe raise a separate issue to discuss it though?
There was a problem hiding this comment.
FWIW #5450 indicates that a 1m service side timeout parameter is applied to all requests
thbkrkr
reviewed
Mar 10, 2022
pkg/controller/elasticsearch/certificates/transport/reconcile.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
…stic#5461) Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5450
This PR proposes to do a GET (from cache) before DELETE to minimise impact on the API server. Alternative approach I could think of is to track the deletion in the orchestration hints annotation but that seemed costly/complicated compared to the almost free GET request.