Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report total managed memory in GiB and raw bytes #5527

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Mar 28, 2022

  • Reports the total managed memory in GiB (1024³ bytes) instead of GB (1000³ bytes) and in raw bytes to avoid confusion, in the elastic-licensing ConfigMap.

Before:

{
  ...
  "total_managed_memory": "68.72GB"
}

After:

{
   ...
  "total_managed_memory_bytes": "68719476736",
  "total_managed_memory": "64.00GiB"
}
  • The calculation of ERUs is also updated to use GiB instead of GB.

Resolves #5465.

@thbkrkr thbkrkr added the >enhancement Enhancement of existing functionality label Mar 28, 2022
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thbkrkr thbkrkr merged commit c800408 into elastic:main Mar 31, 2022
@thbkrkr thbkrkr deleted the explicit-reported-total-managed-memory branch May 17, 2022 09:50
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
* Report total managed memory in GiB and raw bytes instead of GB
* Calculate ERUs using 64GiB instead of 64GB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v2.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Licence total_managed_memory computed using decimal GB but memory sizes typically use binary GiB
2 participants