Upgrade PodDisruptionBudget from v1beta1 to v1 #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previous build failed with: 🤔 |
thbkrkr
reviewed
May 30, 2022
This was referenced May 31, 2022
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
* Move PodDisruptionBudget from v1beta1 to v1 * Use reconciler.ReconcileResource(..) on PodDisruptionBudget * Detect policy API version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #5689 by adding a mechanism to detect which version of the
policygroup is available.policy/v1beta1API version of PodDisruptionBudget will no longer be served in1.25policy/v1version is available since1.21The purpose of this new PR is then mostly for ECK
2.3.0to be able to run on K8S1.20Note that the conversion code is not exported to
k8s.io/api, which means that it's not possible to reuse the native conversion mechanism.