Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RevisionHistoryLimit in Deployment and Daemonset for Elastic Agent #5790

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Support RevisionHistoryLimit in Deployment and Daemonset for Elastic Agent #5790

merged 4 commits into from
Jun 20, 2022

Conversation

knechtionscoding
Copy link
Contributor

Closes #5789

I'm not sure why the tests are failing. But this is a start of a PR at least. I think I tracked down all the places this field was set for the agent.

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

3 similar comments
@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the triage label Jun 16, 2022
@knechtionscoding knechtionscoding mentioned this pull request Jun 16, 2022
Closed
@thbkrkr thbkrkr added the >feature Adds or discusses adding a feature to the product label Jun 17, 2022
@botelastic botelastic bot removed the triage label Jun 17, 2022
@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 17, 2022 •
edited
Loading

the tests are failing

No, they haven't been executed yet,

Jenkins test this please (which can only be invoked by Elastic folks).

@knechtionscoding
Copy link
Contributor Author

the tests are failing

No, they haven't been executed yet,

Jenkins test this please (which can only be invoked by Elastic folks).

No, they are failing locally. I just am not sure why. I didn't think I changed anything related to the one test failing. Sorry, I should have been more clear.

@thbkrkr thbkrkr self-assigned this Jun 17, 2022
@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 17, 2022

I just am not sure why. I didn't think I changed anything related to the one test failing. Sorry, I should have been more clear.

This is a difficult error to debug when you don't know. TestReconcileAgent_Reconcile failed because the Agent resource was not considered reconciled because with the new field the template hash we put in a label changed.

@thbkrkr thbkrkr changed the title feat: add revisionHistoryLimit Support RevisionHistoryLimit in Deployment and Daemonset for Elastic Agent Jun 17, 2022
@thbkrkr thbkrkr added the v2.4.0 label Jun 17, 2022
@thbkrkr
Copy link
Contributor

thbkrkr commented Jun 17, 2022

Jenkins test this please

@thbkrkr thbkrkr merged commit f41ecf3 into elastic:main Jun 20, 2022
@knechtionscoding knechtionscoding deleted the feat/addRevisionHistoryLimit branch June 22, 2022 13:43
@knechtionscoding knechtionscoding mentioned this pull request Jun 22, 2022
Merged
@david-kow david-kow added exclude-from-release-notes Exclude this PR from appearing in the release notes >enhancement Enhancement of existing functionality and removed >feature Adds or discusses adding a feature to the product labels Aug 3, 2022
@david-kow
Copy link
Contributor

Excluding from release notes as title of #5818 covers this.

fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
@knechtionscoding @thbkrkr @fantapsody
Support RevisionHistoryLimit in Deployment and Daemonset for Elastic …
eb4627c 
…Agent (elastic#5790)

* feat: add revisionHistoryLimit
* make generate
* Update unit test
* Update pkg/apis/agent/v1alpha1/agent_types.go

Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr approved these changes

Assignees

@thbkrkr thbkrkr

Labels
>enhancement Enhancement of existing functionality exclude-from-release-notes Exclude this PR from appearing in the release notes v2.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support RevisionHistoryLimit in Deployment and Daemonset for Elastic Agents
4 participants
@knechtionscoding @elasticmachine @thbkrkr @david-kow