Don't log non-standard ES JSON error responses as errors #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkbay
approved these changes
Sep 7, 2022
| @@ -277,6 +277,16 @@ func TestAPIError_Error(t *testing.T) { | |||
| `Type:illegal_argument_exception} Reason:illegal value can't update [discovery.zen.minimum_master_nodes] from [1] to [6] Type:illegal_argument_exception ` + | |||
| `StackTrace: RootCause:[{Reason:[stack-sample-es-575vhzs8ln][10.60.1.22:9300][cluster:admin/settings/update] Type:remote_transport_exception}]}}`, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
nit: the changes in pkg/controller/elasticsearch/client/error.go have no effect on the value returned by apiError.Error(), unless I'm missing something I don't think this test brings more value than the existing ones?
There was a problem hiding this comment.
You are right about that. I added it because I felt we were missing the case where we have an HTTP error status code but a regular Elasticsearch REST response in the body of the request.
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5473
Only controversial bit is maybe the logging of the whole response body but I thought it might be acceptable as the client is always Elasticsearch we roughly know the responses that are being returned. However a proxy in-between like Envoy might change that. Curious about your thoughts.