Elasticsearch observer improvements to avoid blocking between workers. #6084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a few improvements on the observer:
Service
is not "ready"observer.Start()
is invoked outside of any lock-protected sectionobserver.observe(...)
I eventually decided to not introduce a custom, low, timeout as suggested in #6078 for the following reasons:
_cluster/health
is slow then chances are that it'll also be the case for subsequent API calls, not sure why we would treat this one as a special case.Fixes #6078