Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yaml Kibana example in saml authentication doc #6301

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix yaml Kibana example in saml authentication doc #6301

merged 1 commit into from
Jan 12, 2023

Conversation

JohannesMahne
Copy link
Contributor

@JohannesMahne JohannesMahne commented Jan 10, 2023 •
edited by thbkrkr
Loading

Fixing hierarchy of Kibana yaml example in SAML authentication doc.

@botelastic botelastic bot added the triage label Jan 10, 2023
@pebrc pebrc added the >docs Documentation label Jan 10, 2023
@botelastic botelastic bot removed the triage label Jan 10, 2023
pebrc
pebrc previously approved these changes Jan 10, 2023
View reviewed changes
@pebrc pebrc dismissed their stale review January 10, 2023 15:50

wrong target branch

@pebrc
Copy link
Collaborator

pebrc commented Jan 10, 2023 •
edited
Loading

@JohannesMahne thanks for your PR can you please re-target it to the main branch. We can then later back port it to all affected versions.

@pebrc pebrc changed the base branch from 2.3 to main January 10, 2023 15:57
@pebrc pebrc changed the base branch from main to 2.3 January 10, 2023 15:57
@thbkrkr thbkrkr changed the title Wrong yaml hierarchy Fix yaml kibana example in saml authentication doc Jan 10, 2023
@thbkrkr thbkrkr added the v2.7.0 label Jan 10, 2023
@JohannesMahne JohannesMahne changed the base branch from 2.3 to main January 11, 2023 09:50
@JohannesMahne
Copy link
Contributor Author

@pebrc - can you please assist? It seems I am not authorised to merge this PR to main.

@pebrc
Copy link
Collaborator

pebrc commented Jan 11, 2023 •
edited
Loading

Can you rebase your change on main? Or open a new PR if that's easier. We will merge it for you afterwards.

@thbkrkr
Copy link
Contributor

thbkrkr commented Jan 12, 2023

I'll take care of the rebase.

@thbkrkr thbkrkr force-pushed the JohannesMahne-patch-1 branch from eae555b to 905ec10 Compare January 12, 2023 16:48
@thbkrkr thbkrkr merged commit 73852c8 into main Jan 12, 2023
@thbkrkr thbkrkr deleted the JohannesMahne-patch-1 branch February 2, 2023 09:19
@thbkrkr thbkrkr changed the title Fix yaml kibana example in saml authentication doc Fix yaml Kibana example in saml authentication doc Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr approved these changes

@pebrc pebrc pebrc left review comments

Assignees
No one assigned
Labels
>docs Documentation v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohannesMahne @pebrc @thbkrkr