Create Elasticsearch client for observer only if needed #6407
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| defer tracing.Span(&ctx)() | ||
| nsName := k8s.ExtractNamespacedName(&cluster) | ||
| settings := m.extractObserverSettings(ctx, cluster) | ||
|
|
||
| observer, exists := m.getObserver(nsName) | ||
|
|
||
| var esClient client.Client | ||
| if exists { | ||
| esClient = esClientProvider(observer.esClient) |
There was a problem hiding this comment.
We are effectively doing the comparison twice now here and on L88. Not sure if it worth optimising this further Equals is pretty fast.
There was a problem hiding this comment.
I think for readability it is better to carry out the comparison twice.
Co-authored-by: Peter Brachwitz <peter.brachwitz@gmail.com>
|
buildkite test this |
|
@elasticmachine run elasticsearch-ci/docs |
barkbay
changed the title
barkbay
changed the title
This PR implements the functionality to create a new ES client for the observer only if needed, i.e. if there are changes in the client config.
It fixes #6090