Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation note for APM Server standalone #6601

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

kruskall
Copy link
Member

Remove deprecation note for APM Server standalone.
Also remove the deprecation notice from the documentation

Closes #6207

@botelastic botelastic bot added the triage label Mar 28, 2023
@thbkrkr thbkrkr added >bug Something isn't working exclude-from-release-notes Exclude this PR from appearing in the release notes v2.8.0 labels Mar 28, 2023
@botelastic botelastic bot removed the triage label Mar 28, 2023
@thbkrkr
Copy link
Contributor

thbkrkr commented Mar 28, 2023

buildkite test this

FAIL:

pkg/controller/apmserver/controller.go:13:2: "github.com/blang/semver/v4" imported as semver and not used

@thbkrkr
Copy link
Contributor

thbkrkr commented Mar 28, 2023

"github.com/blang/semver/v4"

is not used and needs to be removed.

@thbkrkr thbkrkr changed the title feat: remove deprecation note for APM Server standalone Remove deprecation note for APM Server standalone Mar 28, 2023
@thbkrkr thbkrkr added v2.7.0 and removed v2.8.0 labels Mar 28, 2023
@thbkrkr thbkrkr merged commit 25d6258 into main Mar 28, 2023
thbkrkr pushed a commit to thbkrkr/cloud-on-k8s that referenced this pull request Mar 28, 2023
This removes the deprecation warning about the standalone APM Server binary
because the focus shifted towards the Elastic Agent managed APM Server and
eventually the standalone server has not been deprecated.
@thbkrkr thbkrkr deleted the feat/remove-deprecation-standalone branch March 28, 2023 13:36
thbkrkr added a commit that referenced this pull request Mar 28, 2023
This removes the deprecation warning about the standalone APM Server binary
because the focus shifted towards the Elastic Agent managed APM Server and
eventually the standalone server has not been deprecated.

Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
@thbkrkr thbkrkr added >enhancement Enhancement of existing functionality and removed >bug Something isn't working exclude-from-release-notes Exclude this PR from appearing in the release notes labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecation note for APM Server standalone
2 participants