Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation to specify affinity, nodeSelector and tolerations in operator Helm chart #7084

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

smcavallo
Copy link
Contributor

Signed-off-by: smcavallo smcavallo@hotmail.com

Fixes the indentation. Required in order to configure these settings.
helm template --values=values.yaml .

nodeSelector:
  kubernetes.io/os: linux

affinity:
  nodeAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      nodeSelectorTerms:
        - matchExpressions:
            - key: my-nodegroup-key
              operator: In
              values:
                - my-nodegroup-value

See before and after:
image

Signed-off-by: smcavallo <smcavallo@hotmail.com>
@cla-checker-service
Copy link

cla-checker-service bot commented Aug 4, 2023

💚 CLA has been signed

@botelastic botelastic bot added the triage label Aug 4, 2023
@smcavallo smcavallo closed this Aug 4, 2023
@smcavallo smcavallo reopened this Aug 4, 2023
@naemono naemono self-assigned this Aug 17, 2023
@naemono
Copy link
Contributor

naemono commented Aug 17, 2023

image

Verified. Will get this merged shortly.

@naemono
Copy link
Contributor

naemono commented Aug 17, 2023

buildkite test this

@naemono
Copy link
Contributor

naemono commented Aug 17, 2023

@elasticmachine run elasticsearch-ci/docs

@naemono
Copy link
Contributor

naemono commented Aug 17, 2023

@smcavallo thanks for this!

Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@naemono naemono merged commit e24e980 into elastic:main Aug 17, 2023
@smcavallo smcavallo deleted the helm-affinity branch August 18, 2023 23:22
@thbkrkr thbkrkr added >bug Something isn't working v2.10.0 labels Aug 28, 2023
@botelastic botelastic bot removed the triage label Aug 28, 2023
@thbkrkr thbkrkr changed the title helm - affinity nodeSelector tolerations indentation Fix indentation to specify affinity, nodeSelector and tolerations in Helm chart Aug 28, 2023
@rhr323 rhr323 changed the title Fix indentation to specify affinity, nodeSelector and tolerations in Helm chart Fixed indentation to specify affinity, nodeSelector and tolerations in Helm chart Oct 25, 2023
@thbkrkr thbkrkr changed the title Fixed indentation to specify affinity, nodeSelector and tolerations in Helm chart Fix indentation to specify affinity, nodeSelector and tolerations in operator Helm chart Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working :helm-charts v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants