-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes and highlights for 2.10.0 release #7264
Conversation
0bbee5e
to
5187126
Compare
Both release notes, and highlights are included in this PR, marking as ready for review. |
Adding Agent running as non-root to highlights. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing, let's change the link in the highlights to the docs not the full example. Otherwise LGTM
[id="{p}-2100-agent-non-root"] | ||
=== Running Elastic Agent as non-root | ||
|
||
ECK 2.10.0 supports running Elastic Agent without running the Pod as the root user. (see https://github.com/elastic/cloud-on-k8s/tree/main/config/recipes/elastic-agent/fleet-kubernetes-integration-noroot.yaml[example]). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to the documentation instead which provides more context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pebrc , looks like the link got lost somewhere, could you paste it here again? 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not include the link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if this is not what you meant: 64ee7c6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Peter means this link: https://www.elastic.co/guide/en/cloud-on-k8s/2.10/k8s-elastic-agent-fleet-configuration.html#k8s-elastic-agent-running-as-a-non-root-user @rhr323 (This link isn't valid atm, but will be once the documentation is released. You can see it if you change 2.10 => master)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that was helpful. Link updated.
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Co-authored-by: Michael Montgomery <mmontg1@gmail.com> (cherry picked from commit f8f3e60)
[id="{p}-2100-agent-non-root"] | ||
=== Running Elastic Agent as non-root | ||
|
||
ECK 2.10.0 supports running Elastic Agent without running the Pod as the root user (see https://www.elastic.co/guide/en/cloud-on-k8s/master/k8s-elastic-agent-fleet-configuration.html#k8s-elastic-agent-running-as-a-non-root-user[documentation]). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not include links like this but use the <<>>
syntax and use the anchor for the relevant page.
This PR adds the release notes and highlights for the 2.10.0 release.
TODO: