[DOCFIX] makes plugin installation via initContainer more robust #7305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove plugin before installing it to prevent edge cases where initContainer starts crashing loopback after installation failed
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I added a second commit to fix the other files as well |
thbkrkr
reviewed
Nov 10, 2023
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
thbkrkr
approved these changes
Nov 10, 2023
thbkrkr
reviewed
Nov 10, 2023
docs/orchestrating-elastic-stack-applications/elasticsearch/bundles-plugins.asciidoc
Show resolved
Hide resolved
thbkrkr
reviewed
Nov 13, 2023
docs/orchestrating-elastic-stack-applications/elasticsearch/bundles-plugins.asciidoc
Show resolved
Hide resolved
…ndles-plugins.asciidoc Co-authored-by: Jean-Fabrice Bobo <2949987+jeanfabrice@users.noreply.github.com>
|
Thank you Thibault! |
robbavey
pushed a commit
to robbavey/cloud-on-k8s
that referenced
this pull request
Dec 20, 2023
…lastic#7305) Removes plugin before installing it to prevent edge cases where initContainer starts crashing loopback when plugin installation failed partially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes plugin before installing it to prevent edge cases where initContainer starts crashing loopback when plugin installation failed partially.