Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty NODE_ID in Elasticsearch PreStop hook #7892

Merged
merged 34 commits into from
Jul 4, 2024
Merged

Handle empty NODE_ID in Elasticsearch PreStop hook #7892

merged 34 commits into from
Jul 4, 2024

Commits on Jun 12, 2024

  1. fix: cleanup pre-stop-hook-script.sh

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    482f23b View commit details
    Browse the repository at this point in the history

  2. fix: update the exit default from delayed_exit

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fb62e1d View commit details
    Browse the repository at this point in the history

  3. fix: use spaces inside shellscript

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9561a9f View commit details
    Browse the repository at this point in the history

  4. fix: use spaces inside shellscript

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    1442ef1 View commit details
    Browse the repository at this point in the history

  5. fix: cleanup grep for NODE_ID

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    18f1b87 View commit details
    Browse the repository at this point in the history

  6. fix: spaces before param

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    46d08b3 View commit details
    Browse the repository at this point in the history

  7. fix: update retry to 7

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8f53e76 View commit details
    Browse the repository at this point in the history

  8. fix: temp return expanded param for basic auth (wrong)

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    c3a8fd9 View commit details
    Browse the repository at this point in the history

  9. fix: update retry to 8

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    99a6d51 View commit details
    Browse the repository at this point in the history

  10. fix: add working version with alot of debug info

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9e22058 View commit details
    Browse the repository at this point in the history

  11. fix: cleanup debug code

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    452fb48 View commit details
    Browse the repository at this point in the history

  12. fix: remove comments

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8f1cea9 View commit details
    Browse the repository at this point in the history

  13. fix: update retry to 8

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0e8c5c4 View commit details
    Browse the repository at this point in the history

  14. fix; update set flags

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    6ee066b View commit details
    Browse the repository at this point in the history

  15. fix: remove comments

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    2954da3 View commit details
    Browse the repository at this point in the history

  16. fix: use simpel definition for argument parameter

    @BobVanB
    BobVanB committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d8db45d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Merge branch 'main' into pre-stop-hook-script

    @BobVanB
    BobVanB authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ecf5746 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pre-stop-hook-script

    @BobVanB
    BobVanB authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    48e005c View commit details
    Browse the repository at this point in the history

  3. fix: correct BASIC_AUTH array

    @BobVanB
    BobVanB committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    03d6bc0 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. fix: remove shellcheck disabled comment

    @BobVanB
    BobVanB committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cf587e6 View commit details
    Browse the repository at this point in the history

  2. fix: prevent globbing

    @BobVanB
    BobVanB committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    97f12ed View commit details
    Browse the repository at this point in the history

  3. fix: globbing message

    @BobVanB
    BobVanB committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    cb2bf9e View commit details
    Browse the repository at this point in the history

  4. fix: smaller footprint

    @BobVanB
    BobVanB committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    29234cd View commit details
    Browse the repository at this point in the history

  5. fix: smaller footprint

    @BobVanB
    BobVanB committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a74bc1d View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Update pkg/controller/elasticsearch/nodespec/lifecycle_hook.go 

    You got me on this one. Didn't show up during testing.
Normally i always assign the variables i expect during the function start with a local variable, this way i would always check them later on.

And i would like to recommend creating a library with functions that can be used across the other scripts.
This way the library can be tested with shellspec, very easy and helpful.

Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
    @BobVanB @thbkrkr
    BobVanB and thbkrkr authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    acdf865 View commit details
    Browse the repository at this point in the history

  2. Update pkg/controller/elasticsearch/nodespec/lifecycle_hook.go 

    Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
    @BobVanB @thbkrkr
    BobVanB and thbkrkr authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2e6ea64 View commit details
    Browse the repository at this point in the history

  3. Update pkg/controller/elasticsearch/nodespec/lifecycle_hook.go 

    You got me.

Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
    @BobVanB @thbkrkr
    BobVanB and thbkrkr authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b85c7e8 View commit details
    Browse the repository at this point in the history

  4. Update pkg/controller/elasticsearch/nodespec/lifecycle_hook.go 

    Allow the '-' character.
    @BobVanB
    BobVanB authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    a56d570 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Merge branch 'main' into pre-stop-hook-script

    @BobVanB
    BobVanB authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4cc0bd0 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. fix: return grep to original

    @BobVanB
    BobVanB committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    5f955e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Update pkg/controller/elasticsearch/nodespec/lifecycle_hook.go 

    This should be quoted.
    @BobVanB
    BobVanB authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e7c69da View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Merge branch 'main' into pre-stop-hook-script

    @BobVanB
    BobVanB authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    94ca9f9 View commit details
    Browse the repository at this point in the history

  2. Variabilize and comment magic number

    @thbkrkr
    thbkrkr committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3285537 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Merge branch 'main' into pre-stop-hook-script

    @BobVanB
    BobVanB authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    953cf00 View commit details
    Browse the repository at this point in the history