Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on SAML Authentication docs page #7950

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix typo on SAML Authentication docs page #7950

merged 1 commit into from
Jul 22, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Jul 22, 2024

This was reported in the docs Slack channel for the SAML Authentication page:


We have sp.acs: https://kibana.example.com/api/security/callback/saml Where it should be /api/security/saml/callback?

@thbkrkr I wasn't sure who to ask to review, so I hope you don't mind that I tagged you.

This was reported in the `docs` Slack channel for the [SAML Authentication](https://www.elastic.co/guide/en/cloud-on-k8s/master/k8s-saml-authentication.html) page:

---

We have `sp.acs: https://kibana.example.com/api/security/callback/saml` Where it should be `/api/security/saml/callback?`
@kilfoyle kilfoyle added the >docs Documentation label Jul 22, 2024
@kilfoyle kilfoyle requested a review from thbkrkr July 22, 2024 14:08
@thbkrkr
Copy link
Contributor

thbkrkr commented Jul 22, 2024

@thbkrkr I wasn't sure who to ask to review, so I hope you don't mind that I tagged you.

No worries. No real need to set reviewers in this repo. The whole team takes turns reviewing.

@thbkrkr thbkrkr merged commit b84fc60 into main Jul 22, 2024
5 checks passed
@thbkrkr thbkrkr deleted the kilfoyle-patch-1 branch July 22, 2024 15:01
thbkrkr pushed a commit that referenced this pull request Jul 22, 2024
This fixes a typo in an URL mentiioned in the SAML Authentication docs page.
thbkrkr added a commit that referenced this pull request Jul 22, 2024
This fixes a typo in an URL mentiioned in the SAML Authentication docs page.

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs Documentation v2.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants