Azure: Dynamically get subscription ID(s) #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Allure Report - 💚 No failures were reported.
|
I've confirmed that with the ARM deployment method, this only retrieves one ID instead of the two I am able to see with my account. This is true both when the role assignment is in the resource group level and the subscription level.
orestisfl
force-pushed
the
azure-subscription-ids
branch
from
d3f8e3c to
2cd0780
Compare
orestisfl
commented
Sep 26, 2023
| }, nil | ||
| } | ||
|
|
||
| func (p *ProviderInitializer) getSubscriptionIds(ctx context.Context, azureConfig auth.AzureFactoryConfig) ([]*string, error) { | ||
| // TODO: mockable |
There was a problem hiding this comment.
Init() is not tested so I consider it out of scope to test this function for now, we should handle this technical debt after the feature freeze though
jeniawhite
approved these changes
Sep 28, 2023
This was referenced Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Azure: Dynamically get subscription ID(s)
I've confirmed that with the ARM deployment method, this only retrieves one ID instead of the two I am able to see with my account. This is true both when the role assignment is in the resource group level and the subscription level.
Related Issues
Checklist