Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #2530) Fix GCP deployment manager formatting #2567

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 30, 2024

Summary of your changes

there were 2 issues preventing GCP CSPM on agentless from successfully deploying a service account for organizations. the first was a slightly off copy-paste command in kibana which ended up not passing ORG_ID to the deployment script, so the deployment assumed it's for a project. the second issue, after providing ORG_ID, the deployment script complained about it being a number and not a string (as per its schema). this is what this PR fixes.

after fixing both of these, i've deployed GCP CSPM on agentless and got findings for an organization account:

Screenshot/Data

Screenshot 2024-09-15 at 17 59 46

Related Issues


This is an automatic backport of pull request #2530 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner September 30, 2024 08:36
@mergify mergify bot added the backport label Sep 30, 2024
@mergify mergify bot assigned orouz Sep 30, 2024
@orouz orouz merged commit 64d1535 into 8.x Sep 30, 2024
11 checks passed
@orouz orouz deleted the mergify/bp/8.x/pr-2530 branch September 30, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant