-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Salesforce] Add custom objects and fields support via Advanced Sync Rules #1938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better! Left some suggestions to finish removing duplicate properties but to default to the Salesforce names for fields, rather than our own names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
💔 Failed to create backport PR(s)The backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
@seanstory is this a breaking change? |
@leemthompo yes, the structure changes would break any existing search experience or client code that relied on specific field names in the documents. Since this connector was not yet GA, PM determined that such a change was acceptable. |
Cool just wondering if we need to explicitly call it out as such. cc @ppf2 |
I think it can be helpful to add something to the release notes, maybe under enhancements instead of breaking change (since the connector is not GA)? What will happen when upgrading to 8.12? Will the existing search index fields be migrated to the new schema or will users have to recreate the connector and search index once on 8.12 and re-sync? @seanstory |
Relates to #1859
This PR contains the following Salesforce connector changes:
Refer this Advanced Sync Rules discussion documentation for the schema: link
Checklists
Pre-Review Checklist
v7.13.2
,v7.14.0
,v8.0.0
)Release Note
This version of the Salesforce connector will change the elastic search document structure. The previous version uses the custom mapping for the salesforce objects but now we do 1:1 representation of Salesforce object in elastic search. The new document structure will be as following: