Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Salesforce] Advanced Sync Rules documentation #1949

Merged
merged 7 commits into from
Dec 11, 2023
Merged

[Salesforce] Advanced Sync Rules documentation #1949

merged 7 commits into from
Dec 11, 2023

Conversation

moxarth-rathod
Copy link
Contributor

Relates to #1859

Documentation for Salesforce Advanced Sync Rules.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes

@moxarth-rathod moxarth-rathod requested a review from a team December 5, 2023 08:53
@moxarth-rathod moxarth-rathod requested review from leemthompo and navarone-feekery and removed request for leemthompo December 5, 2023 08:53
@leemthompo
Copy link
Contributor

@moxarth-elastic you can use the comments on #1936 as a guide to make the headings, formatting, etc. clearer

@moxarth-rathod @seanstory
fix nit
d0de76a 
Co-authored-by: Sean Story <sean.j.story@gmail.com>
wangch079
wangch079 reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@wangch079 wangch079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Indexing and fetch are used interchangeably. The rules are actually applied when fetching data. Can we make it consistent?

@moxarth-rathod
Copy link
Contributor Author

I see Indexing and fetch are used interchangeably. The rules are actually applied when fetching data. Can we make it consistent?

Yes, i've made it consistent.

@moxarth-rathod @navarone-feekery
missing fields
8781fcf 
Co-authored-by: Navarone Feekery <13634519+navarone-feekery@users.noreply.github.com>
navarone-feekery
navarone-feekery approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@navarone-feekery navarone-feekery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moxarth-rathod moxarth-rathod merged commit 300f53e into main Dec 11, 2023
@moxarth-rathod moxarth-rathod deleted the salesforce-asr-documentation branch December 11, 2023 05:45
github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
@moxarth-rathod
[Salesforce] Advanced Sync Rules documentation (#1949)
ac14215
@github-actions github-actions bot mentioned this pull request Dec 11, 2023
Merged
@github-actions GitHub Actions
Copy link

💚 Backport PR(s) successfully created

Status Branch Result
✅ 8.12 #1974

This backport PR will be merged automatically after passing CI.

leemthompo pushed a commit that referenced this pull request Dec 11, 2023
@github-actions @moxarth-rathod
[8.12] [Salesforce] Advanced Sync Rules documentation (#1949) (#1974)
9ab4201 
Co-authored-by: moxarth-elastic <96762084+moxarth-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarone-feekery navarone-feekery navarone-feekery approved these changes

@seanstory seanstory Awaiting requested review from seanstory

@wangch079 wangch079 Awaiting requested review from wangch079

Assignees
No one assigned
Labels
auto-backport salesforce team:external v8.12.0 v8.12.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moxarth-rathod @leemthompo @seanstory @navarone-feekery @wangch079