Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields email-address and locale in Atlassian user document #2053

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

praveen-kukreja
Copy link
Contributor

@praveen-kukreja praveen-kukreja commented Jan 11, 2024

Closes #2026

This change affects user document of Atlassian, which is used in Jira and Confluence connectors. Updated user document will have 2 more fields added email-address and locale for a user document in access control sync.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in Kibana

Changes Requiring Extra Attention

  • Security-related changes (encryption, TLS, SSRF, etc)
  • New external service dependencies added.

Related Pull Requests

Release Note

We added two new fields (locale and email-address) for user document that is indexed during access control sync in Jira and Confluence connectors. Users should run access control sync if these connectors are being used by them.

@praveen-kukreja praveen-kukreja requested a review from a team January 11, 2024 07:13
@praveen-kukreja praveen-kukreja marked this pull request as draft January 11, 2024 07:48
@praveen-kukreja praveen-kukreja marked this pull request as ready for review January 18, 2024 10:12
Copy link
Contributor

@vidok vidok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we add a release note to let customers know they should run access control syn if they've been already using this connector?

@praveen-kukreja
Copy link
Contributor Author

LGTM.

Should we add a release note to let customers know they should run access control syn if they've been already using this connector?

Thanks, added the release note along with the appropriate label in this PR for the same.

@praveen-kukreja praveen-kukreja enabled auto-merge (squash) January 22, 2024 14:32
@praveen-kukreja praveen-kukreja merged commit ba89d70 into main Jan 22, 2024
@praveen-kukreja praveen-kukreja deleted the praveen/confluence-add-relevant-user-fields branch January 22, 2024 14:51
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2053 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Confluence] Add field emailAddress field in Access Control index
2 participants