Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Salesforce] Add custom object support with different API Names #2055

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

moxarth-rathod
Copy link
Contributor

@moxarth-rathod moxarth-rathod commented Jan 11, 2024

Part of #1859

This problem is faced while the API name (which is used in SOQL query to fetch data) is different in the Salesforce edition. I also noticed that the /sobjects endpoint provides the custom objects with the suffix __c, __e and might be some others, so we filter out the custom objects having just __c as a suffix in object API name.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally

Copy link
Contributor

@navarone-feekery navarone-feekery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moxarth-rathod moxarth-rathod enabled auto-merge (squash) January 12, 2024 09:10
@moxarth-rathod moxarth-rathod merged commit 41947e5 into main Jan 12, 2024
@moxarth-rathod moxarth-rathod deleted the support-custom-object-with-different-api-name branch January 12, 2024 09:21
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2055 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants