Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of 'elastic_server' with 'sync_orchestrator' #2076

Merged

Conversation

seanstory
Copy link
Member

I've been wanting to do this forever. The class SyncOrchetrator used to be called just Server and was in the es directory, so instances of it were referred to as elastic_server. Which is a total misnomer of what this is and does.

This is just a global find/replace - no logic changed.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

Copy link
Member

@wangch079 wangch079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@seanstory seanstory enabled auto-merge (squash) January 22, 2024 17:04
@seanstory seanstory merged commit c67d130 into main Jan 22, 2024
@seanstory seanstory deleted the seanstory/rename-elastic-server-var-to-match-class-name branch January 22, 2024 17:11
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2076 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants