Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network Drive] Handle smb connection timeout #2085

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

praveen-kukreja
Copy link
Contributor

Closes #2078

This PR introduces following changes:

  • Add retry mechanism in case of SMB timeouts.
  • Ensure fetch_groups_info is only called when dls is enabled to prevent unnecessary network calls

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in Kibana

Changes Requiring Extra Attention

  • Security-related changes (encryption, TLS, SSRF, etc)
  • New external service dependencies added.

Related Pull Requests

Release Note

The Connection to Network Drive would be re-established and request would be retried in case SMBConnectionClosed error is raised due to timeout while fetching files.

@praveen-kukreja
Copy link
Contributor Author

Buildkite test this

Copy link
Member

@seanstory seanstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveen-kukreja praveen-kukreja enabled auto-merge (squash) January 27, 2024 09:47
@praveen-kukreja praveen-kukreja merged commit cec342f into main Jan 27, 2024
@praveen-kukreja praveen-kukreja deleted the praveen/network-drive-handle-timeouts branch January 27, 2024 09:59
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2085 --autoMerge --autoMergeMethod squash

Copy link

💔 Failed to create backport PR(s)

Status Branch Result
8.11 Commit could not be cherrypicked due to conflicts
8.12 #2094

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2085 --autoMerge --autoMergeMethod squash

artem-shelkovnikov pushed a commit that referenced this pull request Jan 30, 2024
Co-authored-by: Praveen Kukreja <90465691+praveen-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#1266 Connection between the Network Drive Connector and the Network Drive is getting timed out
3 participants