Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add logic to send a ping to connector's backend every loop (#2105)" #2148

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

seanstory
Copy link
Member

This reverts commit 038e472.

This change is a valuable one, but seems to have broken our nightly CI. We can re-introduce it in a follow-up, along with targeted fixes to the Box and Network Drive ftests that were failing. In the mean time, this will unblock some other work.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

Related Pull Requests

@seanstory seanstory requested a review from a team February 12, 2024 21:31
@seanstory seanstory enabled auto-merge (squash) February 12, 2024 21:31
Copy link
Contributor

@markjhoy markjhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seanstory seanstory merged commit be83c52 into main Feb 12, 2024
4 checks passed
@seanstory seanstory deleted the seanstory/fix-ci branch February 12, 2024 21:37
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2148 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants