Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector API] Update postman collection #2156

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Feb 14, 2024

Changes

Update the postman collection to include 8.13 additions to Connector API

Copy link
Member

@artem-shelkovnikov artem-shelkovnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiosity question - why index names and ids are not parametrised?

@jedrazb
Copy link
Member Author

jedrazb commented Feb 15, 2024

Curiosity question - why index names and ids are not parametrised?

Good question, connector ID can be a global param so I adapted the collection. :)

I don't think index_names should be global parameters, they are only used in 2 actions and I think collection user should make a decision what index they are using for testing.

@jedrazb jedrazb enabled auto-merge (squash) February 20, 2024 10:15
@jedrazb jedrazb merged commit b155f2a into main Feb 20, 2024
2 checks passed
@jedrazb jedrazb deleted the jedr-update-connector-api-postman-collection branch February 20, 2024 10:22
Copy link

💚 Backport PR(s) successfully created

Status Branch Result
8.13 #2192

This backport PR will be merged automatically after passing CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants