[Framework] Correctly handle soft deleted connectors #3178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3118
Since we introduced soft-deletes in 9.0, make sure framework respects deleted flag.
Changes
Exclude any connectors with
deleted: true
when fetching supported connectors in a query (note, I added this to native connectors query for conssitency but this code should be deleted anyway #2991)This is in line with how API handles soft-deleted connectors https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ent-search/src/main/java/org/elasticsearch/xpack/application/connector/ConnectorIndexService.java#L410C12-L410C119
Checklists
Pre-Review Checklist
config.yml.example
)v7.13.2
,v7.14.0
,v8.0.0
)Verification
Ran this locally with debug log enabled with ES 9.0. Soft-deleted connector, and that was resulting output of the framework:
Fq4v1pQBjAGa8X_ervuC
was soft deleted so behaviour is correct