Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi arch release #78

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Support multi arch release #78

merged 3 commits into from
Jul 24, 2024

Conversation

airycanon
Copy link
Contributor

@airycanon airycanon commented Apr 10, 2024 •
edited
Loading

fix #57 #71

Changes:

  • add version info by cli option --version
  • using golreaser to build and upload release binary.

@airycanon
Copy link
Contributor Author

airycanon commented Apr 22, 2024 •
edited
Loading

@thbkrkr @tenstad PTAL

@thbkrkr
Copy link
Contributor

thbkrkr commented May 14, 2024

Thanks for taking care of this. I would prefer that we rely on goreleaser/goreleaser-action and also include the version in the binary like here: https://github.com/elastic/eck-diagnostics/blob/main/.github/workflows/release.yml. Could you follow the same approach?

@airycanon airycanon force-pushed the master branch 4 times, most recently from 4e527c9 to aabf3eb Compare May 16, 2024 03:26
@airycanon
Copy link
Contributor Author

airycanon commented May 16, 2024 •
edited
Loading

Thanks for taking care of this. I would prefer that we rely on goreleaser/goreleaser-action and also include the version in the binary like here: https://github.com/elastic/eck-diagnostics/blob/main/.github/workflows/release.yml. Could you follow the same approach?

Thanks for the suggestion. I have already implemented it accordingly, here is a release sample:
https://github.com/airycanon/crd-ref-docs/releases/tag/v0.0.1

the version output:

$ ./crd-ref-docs --version
Version: v0.0.1, Commit: aabf3eb, BuildDate: 2024-05-16T03:28:28Z

@thbkrkr thbkrkr added the enhancement New feature or request label May 16, 2024
@airycanon airycanon mentioned this pull request Jul 17, 2024
Closed
thbkrkr
thbkrkr reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 2 small suggestions but otherwise LGTM!

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
airycanon and others added 2 commits July 24, 2024 10:53
@airycanon @thbkrkr
Update main.go
999bfbf 
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
@airycanon @thbkrkr
Update main.go
f7bdf8f 
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
@airycanon airycanon requested a review from thbkrkr July 24, 2024 07:01
@thbkrkr thbkrkr merged commit a178c7b into elastic:master Jul 24, 2024
2 checks passed
@thbkrkr
Copy link
Contributor

thbkrkr commented Jul 25, 2024

Thank you very much for this contribution.

@thbkrkr thbkrkr mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flag for reading binary version
2 participants
@airycanon @thbkrkr