Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general changes #1

Merged
merged 13 commits into from
Nov 11, 2021
Merged

general changes #1

merged 13 commits into from
Nov 11, 2021

Conversation

oren-zohar
Copy link
Collaborator

@oren-zohar oren-zohar commented Nov 4, 2021 •
edited
Loading

Few notes:

  • maybe we can set all CIS related tags under cis.rego
  • maybe we can create a generic function to iterate every activated rule in data.yaml instead of creating a call for each one in cis.rego
  • fields -> evidence
  • testing infra

kfirpeled
kfirpeled requested changes Nov 4, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
compliance/cis.rego Outdated Show resolved Hide resolved
compliance/lib/osquery.rego Outdated Show resolved Hide resolved
compliance/lib/osquery.rego Outdated Show resolved Hide resolved
compliance/rules/cis_1_1_1/cis_1_1_1.rego Outdated Show resolved Hide resolved
compliance/rules/cis_1_1_2/cis_1_1_2.rego Outdated Show resolved Hide resolved
compliance/rules/cis_1_1_1/cis_1_1_1.rego Outdated Show resolved Hide resolved
compliance/rules/cis_1_1_2/cis_1_1_2.rego Outdated Show resolved Hide resolved
data.yaml Outdated Show resolved Hide resolved
input.json Outdated Show resolved Hide resolved
@oren-zohar oren-zohar requested a review from kfirpeled November 8, 2021 09:58
@oren-zohar oren-zohar mentioned this pull request Nov 9, 2021
Closed
@oren-zohar
Copy link
Collaborator Author

@kfirpeled changed naming of rule packages to contain rule.rego and test.rego each rule still contains the rule id so it's easy to navigate to it by searching the rule id by text

kfirpeled
kfirpeled requested changes Nov 9, 2021
View reviewed changes
compliance/cis.rego Outdated Show resolved Hide resolved
compliance/cis.rego Outdated Show resolved Hide resolved
compliance/cis.rego Outdated Show resolved Hide resolved
compliance/lib/common.rego Outdated Show resolved Hide resolved
compliance/rules/cis_1_1_2/rule.rego Outdated Show resolved Hide resolved
@oren-zohar oren-zohar requested a review from kfirpeled November 10, 2021 12:32
@oren-zohar oren-zohar merged commit b9db385 into main Nov 11, 2021
@oren-zohar oren-zohar deleted the infra_changes branch November 11, 2021 11:09
@kfirpeled kfirpeled linked an issue Nov 11, 2021 that may be closed by this pull request
[csp task] 1.1 Master Node Configuration Files #3
Closed
jeniawhite added a commit to jeniawhite/csp-security-policies that referenced this pull request Aug 9, 2022
@eyalkraft @jeniawhite
@ofiriro3 @uri-weisman @kfirpeled
Generate templates - initial commit (elastic#120)
a0a3b8b 
* Add files via upload

* Update worker.js

* Merge pull request elastic#1 from ofiriro3/editing-readme

Adding information to readme.md

* Merge pull request elastic#2 from ofiriro3/editing-readme

Indentation + path for csp

* Update README.md

Adding a bit of information regarding the manual process of rules

* Merge pull request elastic#3 from jeniawhite/add-json-gen

add json rule generator

* Add an option to generate report for missing rules (elastic#4)

* Rule template schema changes - introducing `metadata` field

* temp solution for merge

* Initial commit

* move to subfolder

* revert temp

* mv .gitattributes

Co-authored-by: Evgeniy Belyi <jeniawhite92@gmail.com>
Co-authored-by: ofiriro3 <ofiriro3@Gmail.com>
Co-authored-by: Uri Weisman <68195305+uri-weisman@users.noreply.github.com>
Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>
orestisfl pushed a commit that referenced this pull request Oct 11, 2023
@eyalkraft @jeniawhite
@ofiriro3 @uri-weisman @kfirpeled @orestisfl
[Security Policies] Generate templates - initial commit (#120)
783a8de 
* Add files via upload

* Update worker.js

* Merge pull request #1 from ofiriro3/editing-readme

Adding information to readme.md

* Merge pull request #2 from ofiriro3/editing-readme

Indentation + path for csp

* Update README.md

Adding a bit of information regarding the manual process of rules

* Merge pull request #3 from jeniawhite/add-json-gen

add json rule generator

* Add an option to generate report for missing rules (#4)

* Rule template schema changes - introducing `metadata` field

* temp solution for merge

* Initial commit

* move to subfolder

* revert temp

* mv .gitattributes

Co-authored-by: Evgeniy Belyi <jeniawhite92@gmail.com>
Co-authored-by: ofiriro3 <ofiriro3@Gmail.com>
Co-authored-by: Uri Weisman <68195305+uri-weisman@users.noreply.github.com>
Co-authored-by: Kfir Peled <61654899+kfirpeled@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

@amirbenun amirbenun Awaiting requested review from amirbenun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[csp task] 1.1 Master Node Configuration Files
2 participants
@oren-zohar @kfirpeled