Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove broken refs #119

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Remove broken refs #119

merged 3 commits into from
Aug 8, 2022

Conversation

eyalkraft
Copy link
Contributor

@eyalkraft eyalkraft commented Aug 8, 2022 •
edited
Loading

@eyalkraft eyalkraft marked this pull request as ready for review August 8, 2022 11:45
@eyalkraft eyalkraft requested a review from a team as a code owner August 8, 2022 11:45
uri-weisman
uri-weisman requested changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@uri-weisman uri-weisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this capability 💪
I've Added a single comment.

cis_policies_generator/src/fixBrokenReferences.ts Outdated
return code == 200;
}
return axios.head(link)
.then(res => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to stick with one convention, async/await or then

@eyalkraft eyalkraft enabled auto-merge (squash) August 8, 2022 13:23
@eyalkraft eyalkraft merged commit d8e6eae into elastic:main Aug 8, 2022
@eyalkraft eyalkraft deleted the remove-broken-refs branch August 8, 2022 13:43
@oren-zohar oren-zohar mentioned this pull request Aug 15, 2022
Closed
orestisfl pushed a commit that referenced this pull request Oct 11, 2023
@eyalkraft @orestisfl
[Security Policies] Remove broken refs (#119)
26adfc7 
* works single threaded

* add concurrency

* use await
orestisfl pushed a commit to orestisfl/csp-security-policies that referenced this pull request Oct 12, 2023
@eyalkraft @orestisfl
[Security Policies] Remove broken refs
a208bb2 
elastic#119

* works single threaded

* add concurrency

* use await


---NOTE---
This is an imported commit, it was initially committed to the
csp-security-policies repo which was then merged into cloudbeat. See:
elastic/cloudbeat#1405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-weisman uri-weisman uri-weisman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyalkraft @uri-weisman