Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing storage account rules after QA cycle #328

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fixing storage account rules after QA cycle #328

merged 1 commit into from
Oct 23, 2023

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Oct 23, 2023 •
edited
Loading

Summary of your changes

After the QA cycle, we've found storage account rules issues.
This PR addresses these issues and fixes them.

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

Note Make sure to bump cloudbeat version/policy.go after merging this PR and drafting a new release.

@jeniawhite jeniawhite requested a review from a team as a code owner October 23, 2023 12:24
@mergify
Copy link

mergify bot commented Oct 23, 2023

This pull request does not have a backport label. Could you fix it @jeniawhite? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@jeniawhite jeniawhite enabled auto-merge (squash) October 23, 2023 12:49
@jeniawhite jeniawhite merged commit 96a437f into elastic:main Oct 23, 2023
4 checks passed
mergify bot pushed a commit that referenced this pull request Oct 23, 2023
@jeniawhite @mergify
Fixing rules after QA (#328)
417eb0a 
(cherry picked from commit 96a437f)
@mergify mergify bot mentioned this pull request Oct 23, 2023
Merged
jeniawhite added a commit that referenced this pull request Oct 24, 2023
@mergify @jeniawhite
Fixing rules after QA (#328) (#329)
6720332 
(cherry picked from commit 96a437f)

Co-authored-by: Evgeniy Belyi <jeniawhite92@gmail.com>
orestisfl pushed a commit to orestisfl/csp-security-policies that referenced this pull request Oct 30, 2023
@jeniawhite @orestisfl
[Security Policies] Fixing rules after QA (elastic#328)
ec14bd0
orestisfl pushed a commit to orestisfl/csp-security-policies that referenced this pull request Oct 30, 2023
@jeniawhite @orestisfl
[Security Policies] Fixing rules after QA
5fc900c 
elastic#328

---NOTE---
This is an imported commit, it was initially committed to the
csp-security-policies repo which was then merged into cloudbeat. See:
elastic/cloudbeat#1405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orestisfl orestisfl orestisfl approved these changes

Assignees

@jeniawhite jeniawhite

Labels
8.11 candidate backport-v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeniawhite @orestisfl