-
Notifications
You must be signed in to change notification settings - Fork 603
Closed
Labels
Team: TRADEdetections-as-codeenhancementNew feature or requestNew feature or requestpythonInternal python for the repositoryInternal python for the repository
Description
dependent on #3817
Summary
This issue is to update how we handle Data Views from Kibana stemming from some feedback Justin had in this comment here.
Within QueryRuleData, we can add a new property index_or_dataview -> list[str] which returns whichever is set. The reason for making it a list even though dataview is a string is because we always iterate, so it saves us from doing a type check every time.
Then, we will need to search for every use of data.index (or rule.contents.data.index and all variations) and replace them with this new property where it makes sense.
To ensure this works properly, the bug in #3817 should be merged first, and backported
Metadata
Metadata
Assignees
Labels
Team: TRADEdetections-as-codeenhancementNew feature or requestNew feature or requestpythonInternal python for the repositoryInternal python for the repository