[Rule Tuning] Reverting Account Password Reset Remotely To Previous Version
#3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrancedejesus
added
Rule: Tuning
terrancedejesus
requested review from
Mikaayenson,
brokensound77,
w0rk3r and
shashank-elastic
shashank-elastic
approved these changes
Apr 18, 2024
Mikaayenson
approved these changes
Apr 18, 2024
Mikaayenson
approved these changes
Apr 18, 2024
terrancedejesus
deleted the
rule-tuning-revert-changes-password-reset-remotely
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Summary
This PR reverts the
Account Password Reset Remotelyrule to the version merged correctly in 7a4f1224dc8c0146b28f21ee87b88d8b685fb0e8.This is the last correct version of the rule that was merged in from #3335 for tuning.
Testing
From this branch, I ran
view-rulewhich showed version 114, then checked out 8.3 and ran the same command to receive the same version, 114. Originally, these versions were split.