[FR] Add max_signal note, unit test, and rule tuning #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikaayenson
added
python
Mikaayenson
requested review from
brokensound77 and
eric-forte-elastic
as code owners
eric-forte-elastic
approved these changes
May 13, 2024
terrancedejesus
approved these changes
May 13, 2024
rules/promotions/credential_access_endgame_cred_dumping_prevented.toml
Outdated
Show resolved
Hide resolved
banderror
reviewed
May 14, 2024
There was a problem hiding this comment.
This is really nice, thanks @Mikaayenson! One suggestion for the wording.
rules/integrations/cloud_defend/container_workload_protection.toml
Outdated
Show resolved
Hide resolved
Mikaayenson
deleted the
3666-rule-tuning-add-unit-test-and-note-for-max_signals
branch
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
Removed changes from: - rules/integrations/cloud_defend/container_workload_protection.toml (selectively cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
Removed changes from: - rules/integrations/cloud_defend/container_workload_protection.toml (selectively cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
Removed changes from: - rules/integrations/cloud_defend/container_workload_protection.toml (selectively cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
Removed changes from: - rules/integrations/cloud_defend/container_workload_protection.toml (selectively cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
Removed changes from: - rules/integrations/cloud_defend/container_workload_protection.toml (selectively cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
(cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
(cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
(cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
(cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
(cherry picked from commit f07a9e6)
protectionsmachine
pushed a commit
that referenced
this pull request
May 14, 2024
(cherry picked from commit f07a9e6)
Closed
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #3666
Summary
max_signalsfield for custom rules in UI [classic] security-docs#5106Bug Fixes
self.assert_