Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Minstack versions for SentinelOne rules #3777

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

shashank-elastic
Copy link
Contributor

@shashank-elastic shashank-elastic commented Jun 11, 2024

Issues

Double Bump in Version Lock #3776

Summary

  • Follow steps of How do I Fix double version bumps for related integrations rules in FAQ
  • Update Min stack version for all affected rules
  • SentinelOne integration version changed across versions documented here

@Mikaayenson
Copy link
Contributor

Do you know why this double bumped? Was it because the integration version changed across versions?

@shashank-elastic
Copy link
Contributor Author

Do you know why this double bumped? Was it because the integration version changed across versions?

Yes @Mikaayenson the versions have changed

In 8.12 and below sample rule snippet SentinelOne Version was 0.1.0


{
  "author": [
    "Elastic"
  ],
  "description": "Identifies the creation of the Antimalware Scan Interface (AMSI) DLL in an unusual location. This may indicate an attempt to bypass AMSI by loading a rogue AMSI module instead of the legit one.",
  "from": "now-9m",
  "index": [
    "winlogbeat-*",
    "logs-endpoint.events.file-*",
    "logs-windows.sysmon_operational-*",
    "endgame-*",
    "logs-sentinel_one_cloud_funnel.*"
  ],
  "language": "eql",
  "license": "Elastic License v2",
  "name": "Suspicious Antimalware Scan Interface DLL",
  <<<READCTED>>>
  "related_integrations": [
    {
      "package": "windows",
      "version": "^1.5.0"
    },
    {
      "package": "endpoint",
      "version": "^8.2.0"
    },
    {
      "package": "sentinel_one_cloud_funnel",
      "version": "^0.1.0"
    }
  ],
  <<READCTED>>
  "timestamp_override": "event.ingested",
  "type": "eql",
  "version": 111
}

In version 8.13 and above sample rule snippet SentinelOne Version was 1.0.0

{
  "author": [
    "Elastic"
  ],
  "description": "Identifies the creation of the Antimalware Scan Interface (AMSI) DLL in an unusual location. This may indicate an attempt to bypass AMSI by loading a rogue AMSI module instead of the legit one.",
  "from": "now-9m",
  "index": [
    "winlogbeat-*",
    "logs-endpoint.events.file-*",
    "logs-windows.sysmon_operational-*",
    "endgame-*",
    "logs-sentinel_one_cloud_funnel.*"
  ],
  "language": "eql",
  "license": "Elastic License v2",
  "name": "Suspicious Antimalware Scan Interface DLL",
<< REDACTED>>
  "related_integrations": [
    {
      "package": "windows",
      "version": "^1.5.0"
    },
    {
      "package": "endpoint",
      "version": "^8.2.0"
    },
    {
      "package": "sentinel_one_cloud_funnel",
      "version": "^1.0.0"
    }
  ],
<<REDACTED>>
  "timestamp_override": "event.ingested",
  "type": "eql",
  "version": 110
}

@terrancedejesus
Copy link
Contributor

terrancedejesus commented Jun 11, 2024

We attempted to avoid this with https://github.com/elastic/detection-rules/pull/3627/files.
Ideally, the rules would be allowed to have a pre-release version. I think the when the code touches here it chooses 1 > 0 and uses that one. The rule in the UI will always point to the latest compatible with the stack, so 8.11 will show a prerelease compatible whereas 8.13 will show the 1.0.0+ for the integration installation.

What we did was allow for rules to have a related integration with only pre-releases but did not solve the SHA256 diff that follows in related integrations when the rule is backported and the field value is dynamically generated. I wouldn't say this is a "bug" either as we expect some rules to have their min-stack bumped when "breaking changes" are introduced to an integration, causing the major to be bumped.

Per conversation with @shashank-elastic - I don't think we should block the release entirely as these rules were released with S1 compatibility in the previous release and therefore will approve.

@shashank-elastic shashank-elastic merged commit 0a69c19 into main Jun 11, 2024
9 checks passed
@shashank-elastic shashank-elastic deleted the fix_sentilone_rules branch June 11, 2024 13:28
protectionsmachine pushed a commit that referenced this pull request Jun 11, 2024
protectionsmachine pushed a commit that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants