Skip to content

[FR] Added Schema Check for Data View ID and Index #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2024
Merged

[FR] Added Schema Check for Data View ID and Index #3830

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0cad13
Added Schema Check for Data View ID and Index
eric-forte-elastic Jun 25, 2024
767fd59
Merge branch 'main' into 3817-bug-schema-should-not-allow-index-and-d…
eric-forte-elastic Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions detection_rules/rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,6 +708,12 @@ def get_required_fields(self, index: str) -> List[dict]:
if validator is not None:
return validator.get_required_fields(index or [])

@validates_schema
def validates_index_and_data_view_id(self, data, **kwargs):
"""Validate that either index or data_view_id is set, but not both."""
if data.get('index') and data.get('data_view_id'):
raise ValidationError("Only one of index or data_view_id should be set.")

@validates_schema
def validates_query_data(self, data, **kwargs):
"""Custom validation for query rule type and subclasses."""
Expand Down