Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tuning] Suspicious WMI Event Subscription Created #4327

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Conversation

Samirbous
Copy link
Contributor

added Elastic Defend Event 5861 (WMI Permanent event subscription event) to this rule scope. this event is part of API events and is emitted by default to the stack/SIEM since it's a low volume event.

https://github.com/elastic/endpoint-rules/issues/3685

@Samirbous Samirbous added Rule: Tuning tweaking or tuning an existing rule OS: Windows windows related rules labels Dec 23, 2024
@Samirbous Samirbous self-assigned this Dec 23, 2024
@protectionsmachine
Copy link
Collaborator

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@Samirbous Samirbous changed the title Update persistence_sysmon_wmi_event_subscription.toml [Tuning] Suspicious WMI Event Subscription Created Dec 23, 2024
@w0rk3r w0rk3r added the minor label Jan 3, 2025
@w0rk3r w0rk3r added patch and removed minor labels Jan 6, 2025
@w0rk3r w0rk3r merged commit 419e5c1 into main Jan 6, 2025
22 checks passed
@w0rk3r w0rk3r deleted the Samirbous-patch-1 branch January 6, 2025 12:40
protectionsmachine pushed a commit that referenced this pull request Jan 6, 2025
* Update persistence_sysmon_wmi_event_subscription.toml

* Update non-ecs-schema.json

* Update persistence_sysmon_wmi_event_subscription.toml

* Update detection_rules/etc/non-ecs-schema.json

* Update pyproject.toml

---------

Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com>

Removed changes from:
- rules/windows/persistence_sysmon_wmi_event_subscription.toml

(selectively cherry picked from commit 419e5c1)
protectionsmachine pushed a commit that referenced this pull request Jan 6, 2025
* Update persistence_sysmon_wmi_event_subscription.toml

* Update non-ecs-schema.json

* Update persistence_sysmon_wmi_event_subscription.toml

* Update detection_rules/etc/non-ecs-schema.json

* Update pyproject.toml

---------

Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com>

Removed changes from:
- rules/windows/persistence_sysmon_wmi_event_subscription.toml

(selectively cherry picked from commit 419e5c1)
protectionsmachine pushed a commit that referenced this pull request Jan 6, 2025
* Update persistence_sysmon_wmi_event_subscription.toml

* Update non-ecs-schema.json

* Update persistence_sysmon_wmi_event_subscription.toml

* Update detection_rules/etc/non-ecs-schema.json

* Update pyproject.toml

---------

Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com>

Removed changes from:
- rules/windows/persistence_sysmon_wmi_event_subscription.toml

(selectively cherry picked from commit 419e5c1)
protectionsmachine pushed a commit that referenced this pull request Jan 6, 2025
* Update persistence_sysmon_wmi_event_subscription.toml

* Update non-ecs-schema.json

* Update persistence_sysmon_wmi_event_subscription.toml

* Update detection_rules/etc/non-ecs-schema.json

* Update pyproject.toml

---------

Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com>

(cherry picked from commit 419e5c1)
protectionsmachine pushed a commit that referenced this pull request Jan 6, 2025
* Update persistence_sysmon_wmi_event_subscription.toml

* Update non-ecs-schema.json

* Update persistence_sysmon_wmi_event_subscription.toml

* Update detection_rules/etc/non-ecs-schema.json

* Update pyproject.toml

---------

Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com>

(cherry picked from commit 419e5c1)
protectionsmachine pushed a commit that referenced this pull request Jan 6, 2025
* Update persistence_sysmon_wmi_event_subscription.toml

* Update non-ecs-schema.json

* Update persistence_sysmon_wmi_event_subscription.toml

* Update detection_rules/etc/non-ecs-schema.json

* Update pyproject.toml

---------

Co-authored-by: Jonhnathan <26856693+w0rk3r@users.noreply.github.com>

(cherry picked from commit 419e5c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto Domain: Endpoint OS: Windows windows related rules patch Rule: Tuning tweaking or tuning an existing rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants