Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion detection_rules/cli_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def rule_prompt( # noqa: PLR0912, PLR0913, PLR0915
# if failing due to a query, loop until resolved or terminated
while True:
try:
contents["query"] = click.edit(contents["query"], extension=".eql")
contents["query"] = click.edit(contents["query"], extension=".eql") # type: ignore[reportUnknownArgumentType]
rule = TOMLRule(
path=Path(path),
contents=TOMLRuleContents.from_dict({"rule": contents, "metadata": meta}),
Expand Down
4 changes: 2 additions & 2 deletions detection_rules/ghwrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def get_gh_release(repo: Repository, release_name: str | None = None, tag_name:

releases = repo.get_releases()
for release in releases:
if (release_name and release_name == release.title) or (tag_name and tag_name == release.tag_name):
if (release_name and release_name == release.name) or (tag_name and tag_name == release.tag_name):
return release
return None

Expand Down Expand Up @@ -211,7 +211,7 @@ def __init__(
raise ValueError(f"No release found for {tag_name or release_name}")

if not self.release_name:
self.release_name = self.release.title
self.release_name = self.release.name

self.manifest_name = f"manifest-{self.release_name}.json"
self.assets = self._get_enriched_assets_from_release()
Expand Down
18 changes: 9 additions & 9 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "detection_rules"
version = "1.5.5"
version = "1.5.6"
description = "Detection Rules is the home for rules used by Elastic Security. This repository is used for the development, maintenance, testing, validation, and release of rules for Elastic Security’s Detection Engine."
readme = "README.md"
requires-python = ">=3.12"
Expand All @@ -19,12 +19,12 @@ classifiers = [
"Topic :: Utilities"
]
dependencies = [
"Click~=8.1.7",
"Click~=8.3.0",
"elasticsearch~=8.12.1",
"eql==0.9.19",
"jsl==0.2.4",
"jsonschema>=4.21.1",
"marko==2.0.3",
"marko==2.2.1",
"marshmallow-dataclass==8.7.1",
"marshmallow-jsonschema~=0.13.0",
"marshmallow-union~=0.1.15",
Expand All @@ -39,19 +39,19 @@ dependencies = [
"typing-extensions>=4.12",
"XlsxWriter~=3.2.0",
"semver==3.0.4",
"PyGithub==2.2.0",
"PyGithub==2.8.1",
"detection-rules-kql @ git+https://github.com/elastic/detection-rules.git#subdirectory=lib/kql",
"detection-rules-kibana @ git+https://github.com/elastic/detection-rules.git#subdirectory=lib/kibana",
"setuptools==78.1.1"
]
[project.optional-dependencies]
dev = [
"pep8-naming==0.13.0",
"flake8==7.0.0",
"pyflakes==3.2.0",
"pep8-naming==0.15.1",
"flake8==7.3.0",
"pyflakes==3.4.0",
"pytest>=8.1.1",
"nodeenv==1.8.0",
"pre-commit==3.6.2",
"nodeenv==1.9.1",
"pre-commit==3.8.0",
"ruff>=0.11",
"pyright>=1.1",
]
Expand Down
Loading