Skip to content

refactor: Dedupe some logic in LlmBlockRenderers #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025
Merged

refactor: Dedupe some logic in LlmBlockRenderers #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
246d7d5
refactor: Dedupe some logic in LlmBlockRenderers
reakaleek Jul 18, 2025
0f5976f
Cleanup
reakaleek Jul 18, 2025
5acae05
Cleanup
reakaleek Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Elastic.Markdown/Helpers/DocumentationObjectPoolProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
using Elastic.Markdown.Myst;
using Elastic.Markdown.Myst.Renderers.LlmMarkdown;
using Markdig.Renderers;
using Markdig.Syntax;
using Microsoft.Extensions.ObjectPool;

namespace Elastic.Markdown.Helpers;
Expand Down
81 changes: 35 additions & 46 deletions src/Elastic.Markdown/Myst/Renderers/LlmMarkdown/LlmBlockRenderers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,25 +279,7 @@ protected override void Write(LlmMarkdownRenderer renderer, Table table)
// Render table header
if (table.Count > 0 && table[0] is TableRow headerRow)
{
renderer.Writer.Write("|");
var cellIndex = 0;
foreach (var cell in headerRow.Cast<TableCell>())
{
renderer.Writer.Write(" ");

// Capture cell content
var content = DocumentationObjectPoolProvider.UseLlmMarkdownRenderer(renderer.BuildContext, cell.Descendants().OfType<Inline>(), static (tmpRenderer, obj) =>
{
foreach (var inline in obj)
tmpRenderer.Write(inline);
});
// Write padded content
renderer.Writer.Write(content.PadRight(columnWidths[cellIndex]));
renderer.Writer.Write(" |");
cellIndex++;
}

renderer.WriteLine();
RenderTableRowCells(renderer, headerRow, columnWidths);

// Render separator row with proper alignment
renderer.Writer.Write("|");
Expand All @@ -313,27 +295,26 @@ protected override void Write(LlmMarkdownRenderer renderer, Table table)
// Render table body with aligned columns
foreach (var row in table.Skip(1).Cast<TableRow>())
{
renderer.Writer.Write("|");
var cellIndex = 0;
foreach (var cell in row.Cast<TableCell>())
{
renderer.Writer.Write(" ");

// Capture cell content
var content = DocumentationObjectPoolProvider.UseLlmMarkdownRenderer(renderer.BuildContext, cell.Descendants().OfType<Inline>(), static (tmpRenderer, obj) =>
{
foreach (var inline in obj)
tmpRenderer.Write(inline);
});

// Write padded content
renderer.Writer.Write(content.PadRight(columnWidths[cellIndex]));
renderer.Writer.Write(" |");
cellIndex++;
}
RenderTableRowCells(renderer, row, columnWidths);
}
}

renderer.WriteLine();
/// <summary>
/// Renders a table row with proper cell alignment and padding
/// </summary>
private static void RenderTableRowCells(LlmMarkdownRenderer renderer, TableRow row, int[] columnWidths)
{
renderer.Writer.Write("|");
var cellIndex = 0;
foreach (var cell in row.Cast<TableCell>())
{
renderer.Writer.Write(" ");
var content = RenderTableCellContent(renderer, cell);
renderer.Writer.Write(content.PadRight(columnWidths[cellIndex]));
renderer.Writer.Write(" |");
cellIndex++;
}
renderer.WriteLine();
}

/// <summary>
Expand All @@ -352,24 +333,32 @@ private static int[] CalculateColumnWidths(LlmMarkdownRenderer renderer, Table t
// Process all rows to find maximum width for each column
foreach (var row in table.Cast<TableRow>())
{
var cellIndex = 0;
foreach (var cell in row.Cast<TableCell>())
for (var cellIndex = 0; cellIndex < row.Count; cellIndex++)
{
var cell = row[cellIndex] as TableCell;
// Capture cell content
var content = DocumentationObjectPoolProvider.UseLlmMarkdownRenderer(renderer.BuildContext, cell.Descendants().OfType<Inline>(), static (tmpRenderer, obj) =>
{
foreach (var inline in obj)
tmpRenderer.Write(inline);
});
var content = RenderTableCellContent(renderer, cell!);

// Update width if this cell is wider
widths[cellIndex] = Math.Max(widths[cellIndex], content.Length);
cellIndex++;
}
}

return widths;
}

/// <summary>
/// Renders the inline content of a table cell to plain text
/// </summary>
private static string RenderTableCellContent(LlmMarkdownRenderer renderer, TableCell cell) =>
DocumentationObjectPoolProvider.UseLlmMarkdownRenderer(
renderer.BuildContext,
cell.Descendants().OfType<Inline>(),
static (tmpRenderer, obj) =>
{
foreach (var inline in obj)
tmpRenderer.Write(inline);
});
}

public class LlmDirectiveRenderer : MarkdownObjectRenderer<LlmMarkdownRenderer, DirectiveBlock>
Expand Down
Loading