feature/config folder arg #1580
Conversation
…hared instances of repository
This allows the build to source the configuration prior to cloning and building
docs-assembler repo init-config
docs-assembler repo clone-all
docs-assembler repo build-all
On production we can lock the configuration to a commit using `--git-ref sha`.
ConfigurationFileProvider will look at
- {pwd}/config, development
- {app_data}/config, (where init-config clones too)
- embedded sources
We also now log the configuration source and in case of app_data also the git reference.
| [EnumExtensions] | ||
| public enum ConfigurationSource | ||
| { | ||
| Local, |
There was a problem hiding this comment.
Can we use local and put the config in elastic/docs-internal-workflows?
There was a problem hiding this comment.
We could, as source of truth or as a copy?
I think we want the source of truth to remain in docs-builder.
There was a problem hiding this comment.
Maybe it's just me. But I like to think that the config is close to the place where it's being deployed from.
There was a problem hiding this comment.
I think config should live where its read.
If it lives in elastic/docs-internal-workflows we'd need multiple copies for each environment.
We can do a lot more PR validations from this repository too IMO. Let's discuss today :)
|
Leaving this open until after |
|
Sounds good. Closes #1434. |
|
Merging this in, we won't use |
This allows the build to source the configuration prior to cloning and building
docs-assembler repo init-config
docs-assembler repo clone-all
docs-assembler repo build-all
On production we can lock the configuration to a commit using
--git-ref sha.I think we want to automate opening PR's to update that sha to the last commit on our
configfolder. We can then merge it once we know staging is still good.ConfigurationFileProvider will look at
We also now log the configuration source and in case of app_data also the git reference.