-
Notifications
You must be signed in to change notification settings - Fork 30
Reference nav reshuffles #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reference nav reshuffles #1921
Conversation
is this still a |
@shainaraskas sorry nope it's no longer a test, this is the real life... fixed the PR title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be nice for the next reviewer if you expand the sections that were impacted in your screenshots - found reviewing this to be a little difficult without the preview.
I think this all looks fine, with the exception of what's left of the data analysis section. it's not clearly scoped enough to stand together (contains a mixture of docs related to ML, kibana canvas, and something called the infrastructure app which I have no idea about - perhaps related to apm/obs?)
might not be possible in this PR but would like to know if there is a plan to reorganize that content so it is more discoverable.
# Text analysis | ||
# https://github.com/elastic/elasticsearch/blob/main/docs/reference/text-analysis/toc.yml | ||
- toc: elasticsearch://reference/text-analysis | ||
path_prefix: reference/text-analysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming that the data analysis overview will be updated to reflect this new structure (as well as the other overviews for impacted sections)?
|
||
# Data analysis | ||
# https://github.com/elastic/docs-content/blob/main/reference/data-analysis/toc.yml | ||
- toc: docs-content://reference/data-analysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little confused about what is left in this section. keeping the ML stuff with the canvas stuff feels a little strange
contributes to elastic/docs-content#1644
Notable changes:
Text analysis
andScripting languages
reference sections to be grouped under Elasticsearch, rather than as children of other topics.Kibana
andCloud
documentation sections to appear higher in the navigationIngestion tools
section, moving it up in the hierarchy and grouping EDOT as a childScreenshots
✅ NEW
OLD ❌