Skip to content

fixes and consolidates elasticsearch deploy on windows commands #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Apr 28, 2025

Substitutes #438

Closes #437

It fixes a couple of wrong command execution paths and it also consolidates the command execution examples to ./bin/elasticsearch.... instead of bin/elasticsearch... (using ./ is safer in windows power shell and it's totally valid in Linux).

Also ./bin is already used for a lot linux examples like starting Elasticsearch from the command line.

@eedugon eedugon requested a review from shainaraskas April 28, 2025 19:47
@eedugon eedugon changed the title fixed and consolidated elasticsearch deploy on windows commands fixes and consolidates elasticsearch deploy on windows commands Apr 28, 2025
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, lgtm!

@eedugon eedugon enabled auto-merge (squash) April 30, 2025 05:51
@eedugon eedugon merged commit 441bb97 into main Apr 30, 2025
3 of 4 checks passed
@eedugon eedugon deleted the fix_437 branch April 30, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong path: C:\...\bin>bin\...
2 participants