-
Notifications
You must be signed in to change notification settings - Fork 107
Adds Rollup API examples to 'Get started with rollups using the API' page #1893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a couple of suggestions to improve style.
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Bogi,
This looks great! I've left two minor comments and leave them at your discretion to apply.
Thank you!
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
📸 Preview
This PR adds the Rollup search API examples to the Get started with rollups using the API page, as part of the approach to unify API reference documentation.
Related issue: https://github.com/elastic/docs-projects/issues/302