Skip to content

Adds Rollup API examples to 'Get started with rollups using the API' page #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Jun 24, 2025

📸 Preview

This PR adds the Rollup search API examples to the Get started with rollups using the API page, as part of the approach to unify API reference documentation.

Related issue: https://github.com/elastic/docs-projects/issues/302

@kosabogi kosabogi requested a review from szabosteve June 24, 2025 11:55
@kosabogi kosabogi added the documentation Improvements or additions to documentation label Jun 24, 2025
@kosabogi kosabogi requested a review from a team as a code owner June 24, 2025 11:55
@kosabogi kosabogi added the Team:Developer Issues owned by the Developer Docs Team label Jun 24, 2025
Copy link

github-actions bot commented Jun 24, 2025

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a couple of suggestions to improve style.

kosabogi and others added 5 commits June 26, 2025 10:41
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Co-authored-by: István Zoltán Szabó <szabosteve@gmail.com>
Copy link
Contributor

@yetanothertw yetanothertw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bogi,
This looks great! I've left two minor comments and leave them at your discretion to apply.
Thank you!

kosabogi and others added 2 commits June 26, 2025 11:48
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Team:Developer Issues owned by the Developer Docs Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants