-
Notifications
You must be signed in to change notification settings - Fork 160
ipv6 support for remote addresses added #3361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added extra fixes, as the "Elasticsearch API method" of both ECE -> self-managed and ECH -> self-managed docs were incorrect! |
deploy-manage/remote-clusters/_snippets/rcs-elasticsearch-api-snippet-self.md
Outdated
Show resolved
Hide resolved
…snippet-self.md Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments for you. I think the applies tag needs to be removed from the api instructions
deploy-manage/remote-clusters/_snippets/rcs-kibana-api-snippet-self.md
Outdated
Show resolved
Hide resolved
deploy-manage/remote-clusters/_snippets/rcs-elasticsearch-api-snippet-self.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works. Few minor non blocking suggestions.
Thanks Edu for handling the Kibana part :)
deploy-manage/remote-clusters/_snippets/rcs-kibana-api-snippet-self.md
Outdated
Show resolved
Hide resolved
deploy-manage/remote-clusters/_snippets/rcs-kibana-api-snippet-self.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with florent's comments. otherwise good to go
deploy-manage/remote-clusters/_snippets/rcs-kibana-api-snippet-self.md
Outdated
Show resolved
Hide resolved
I'm sorry I've been fully occupied the last few days by another PR :( I'll try to get to this tomorrow. |
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com> Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Resolved conflicts in remote cluster documentation files: - ec-remote-cluster-self-managed.md - ece-remote-cluster-self-managed.md - remote-clusters-api-key.md - remote-clusters-cert.md Kept IPv6 support functionality from feature branch in all conflicts.
This PR describes that the Stack 9.2 supports IPv6 addresses when configuring a remote cluster within Kibana.
I don't want to highlight that much in our docs, as it doesn't feel necessary (we didn't even mention that we supported IPv4 at all, neither that IPv6 wasn't supported by Kibana (it was supported by Elasticsearch)).
Extra improvements:
Not updated (out of the scope of this PR)
Closes #3093