-
Notifications
You must be signed in to change notification settings - Fork 159
Discover tabs #3446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover tabs #3446
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a few minor suggestions :)
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good on my end, thanks! Left a few nits and suggestions, but nothing blocking.
- Reorder them: Drag and drop a tab to move it. | ||
- Close them: Hover over a tab and select the {icon}`cross` icon. | ||
- Close several tabs at once: When you hover over a tab and select the {icon}`boxes_vertical` **Actions** icon, options let you **Close other tabs** to keep only the active tab open or **Close tabs to the right** to only keep your first tabs and discard any subsequent tabs. | ||
- Reopen recently closed tabs: If you close a tab by mistake, you can retrieve it by selecting the {icon}`boxes_vertical` **Tabs bar menu** icon located at the end of the tab bar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading this, I feel like we should rename the "Tabs bar menu" button in the UI and come back to update these docs later 😅 The plural "tabs" flows a bit oddly and I see you refer to it as "tab bar" in this sentence too. Any suggestions, maybe just "Tabs menu" would work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to call this something with verb, but I find this menu a bit odd and even Manage tabs isn't fully accurate because you can do some actions (access/restore tabs and clear some in batch), but not individual actions :D
Maybe "Tabs menu" would do yes as you suggested. Maybe it's more like a "Tab history" for the current session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's a bit of an odd one and tricky to name. Not 100% sure what to call it yet, but I'm sure we can land on something reasonable. I opened an issue for it here so we don't forget at least: elastic/kibana#239420.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that might be missing is that you can clear all tabs and start a new Discover session using the "+" button in the application menu bar. This gets you out of the currently open Discover session if there is one and starts a fresh unsaved session, which manually closing open tabs doesn't. Maybe this is clear from other parts of the docs though, I didn't check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right I didn't think of this and should call this out. I'll add this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually a bit scary that you can flush your current session without a warning if it has unsaved changes. And if it has never been saved in the 1st place, you also don't get the "unsaved changes" warning. That's cold! 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed 😬 There are definitely still some rough edges around tab management to work through in post-MVP phases. We at least have the recently closed menu to help recover accidentally lost tabs for now, but still worth refining some of these scenarios.
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
This PR:
Closes: #3145